From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hyong Youb Kim <hyonkim@cisco.com>
Subject: Re: [PATCH v3 08/10] doc: describe Rx bytes counter
 behavior for enic
Date: Fri, 9 Mar 2018 09:52:54 +0900
Message-ID: <20180309005253.GA19460@HYONKIM-FTCPE.cisco.com>
References: <20180306014634.28398-2-johndale@cisco.com>
 <20180308024702.25974-1-johndale@cisco.com>
 <20180308024702.25974-9-johndale@cisco.com>
 <20180308141427.08475f17@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: John Daley <johndale@cisco.com>, ferruh.yigit@intel.com, dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88])
 by dpdk.org (Postfix) with ESMTP id 1E76C6CA2
 for <dev@dpdk.org>; Fri,  9 Mar 2018 01:52:59 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20180308141427.08475f17@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Mar 08, 2018 at 02:14:27PM -0800, Stephen Hemminger wrote:
> On Wed,  7 Mar 2018 18:47:00 -0800
> John Daley <johndale@cisco.com> wrote:
> 
> >      'catch-all' filters should be added last.
> >  
> > +- **Statistics**
> > +
> > +  - ``rx_good_bytes`` (ibytes) always includes VLAN header (4B) and CRC bytes (4B).
> > +  - When the NIC drops a packet because the Rx queue has no free buffers,
> > +    ``rx_good_bytes`` still increments by 4B if the packet is not VLAN tagged or
> > +    VLAN stripping is disabled, or by 8B if the packet is VLAN tagged and stripping
> > +    is enabled.
> 
> All drivers must provide consistent statistics!
> That means do NOT include CRC in the rx byte counts.
> Yes, several drivers in DPDK are already broken for this.
> 
> Otherwise there are cases like packets being forwarded from HW NIC to virtio and the counts
> differ and customers think data is lots.

Thanks for sharing this specific use case issue.

We are aware that our current counters are non-standard. Newer 100G
hardware models have fixed the problem (i.e. no CRC bytes, no
incrementing of bytes when no buffers). We plan to update the doc
again when we add these newer models to the supported hardware list.

As for older models, we will see if we can fix up stats in software..

-Hyong