From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 0/2] lib: move Netlink wrapper to lib Date: Wed, 14 Mar 2018 08:17:36 -0700 Message-ID: <20180314081736.6b06dd2f@xeon-e3> References: <20180313142031.3fd01cbc@xeon-e3> <20180314120855.avapkwbwx6hecwmw@laranjeiro-vm.dev.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Pascal Mazon , dev@dpdk.org To: =?UTF-8?B?TsOpbGlv?= Laranjeiro Return-path: Received: from mail-pl0-f67.google.com (mail-pl0-f67.google.com [209.85.160.67]) by dpdk.org (Postfix) with ESMTP id 029FE4C9D for ; Wed, 14 Mar 2018 16:17:41 +0100 (CET) Received: by mail-pl0-f67.google.com with SMTP id w15-v6so1867952plq.9 for ; Wed, 14 Mar 2018 08:17:41 -0700 (PDT) In-Reply-To: <20180314120855.avapkwbwx6hecwmw@laranjeiro-vm.dev.6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 14 Mar 2018 13:08:55 +0100 N=C3=A9lio Laranjeiro wrote: > On Tue, Mar 13, 2018 at 02:20:31PM -0700, Stephen Hemminger wrote: > > On Tue, 13 Mar 2018 13:28:25 +0100 > > Nelio Laranjeiro wrote: > > =20 > > > TAP PMD uses a wrapper to communicate with Netlink through a socket. = This > > > wrapper can be useful for other PMD which may need to communicate als= o with > > > the Linux kernel via Netlink. > > >=20 > > > This series moves this wrapper to the lib level to let any PMD implem= ent use > > > it when necessary. > > >=20 > > > Nelio Laranjeiro (2): > > > lib: move Netlink code into a common library > > > lib: add request Netlink messages > > >=20 > > > MAINTAINERS | 3 + > > > config/common_base | 6 ++ > > > config/common_linuxapp | 1 + > > > drivers/net/tap/Makefile | 3 +- > > > drivers/net/tap/rte_eth_tap.c | 16 +-- > > > drivers/net/tap/tap_flow.c | 118 ++++++++++-= ---------- > > > drivers/net/tap/tap_netlink.h | 42 -------- > > > drivers/net/tap/tap_tcmsgs.c | 28 ++--- > > > drivers/net/tap/tap_tcmsgs.h | 2 +- > > > lib/Makefile | 2 + > > > lib/librte_netlink/Makefile | 26 +++++ > > > lib/librte_netlink/meson.build | 13 +++ > > > .../librte_netlink/rte_netlink.c | 87 +++++++++++= ---- > > > lib/librte_netlink/rte_netlink.h | 43 ++++++++ > > > lib/librte_netlink/rte_netlink_version.map | 18 ++++ > > > lib/meson.build | 2 +- > > > mk/rte.app.mk | 1 + > > > 17 files changed, 263 insertions(+), 148 deletions(-) > > > delete mode 100644 drivers/net/tap/tap_netlink.h > > > create mode 100644 lib/librte_netlink/Makefile > > > create mode 100644 lib/librte_netlink/meson.build > > > rename drivers/net/tap/tap_netlink.c =3D> lib/librte_netlink/rte_net= link.c (77%) > > > create mode 100644 lib/librte_netlink/rte_netlink.h > > > create mode 100644 lib/librte_netlink/rte_netlink_version.map > > > =20 > >=20 > > I might have raised this before; but having yet another netlink library= is > > not a great advantage. It would be much better to use a common external= library > > libmnl which is already available on every distribution. =20 >=20 > The question is more do we really want to have a dependency on a so > small wrapper for a socket interface? >=20 Lots of drivers already have dependencies. And I trust libmnl rather than a reinvented library.