From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Duszynski Subject: Re: [PATCH] crypto/mrvl: add MRVL to hash test cases Date: Wed, 14 Mar 2018 11:29:52 +0100 Message-ID: <20180314102952.GA8527@sh> References: <1519829633-32295-1-git-send-email-tdu@semihalf.com> <20180308132717.GB22443@sh> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Tomasz Duszynski , "dev@dpdk.org" , "Doherty, Declan" , "Richardson, Bruce" , "stable@dpdk.org" To: "De Lara Guarch, Pablo" Return-path: Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com [209.85.215.49]) by dpdk.org (Postfix) with ESMTP id 2D6445F65 for ; Wed, 14 Mar 2018 11:29:54 +0100 (CET) Received: by mail-lf0-f49.google.com with SMTP id u21-v6so3973688lfc.7 for ; Wed, 14 Mar 2018 03:29:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 14, 2018 at 10:13:58AM +0000, De Lara Guarch, Pablo wrote: > Hi Tomasz, > > > -----Original Message----- > > From: Tomasz Duszynski [mailto:tdu@semihalf.com] > > Sent: Thursday, March 8, 2018 1:27 PM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; Doherty, > > Declan ; Richardson, Bruce > > ; Tomasz Duszynski ; > > stable@dpdk.org > > Subject: Re: [PATCH] crypto/mrvl: add MRVL to hash test cases > > > > This is targetting the crypto tests, so title should be "test/crypto: ...= " Ack. > > > > This patch has been here for a while already. Should I respin it? > > > > On Wed, Feb 28, 2018 at 03:53:53PM +0100, Tomasz Duszynski wrote: > > > MRVL Crypto PMD supports most of the hash algorithms covered by test > > > suites thus specific bits should be set in pmd_masks. > > > > > > Otherwise blockcipher authonly test returns success even though no > > > real tests have been executed. > > > > > > > Fixes: 84e0ded38ac5 ("test/crypto: add mrvl crypto unit tests") > > > Cc: stable@dpdk.org > > I don't think this is a fix, so I would remove the fixes and CC stable li= nes. Why? I think this should have been here since introduction on mrvl/cryto. If you take a look at 84e0ded38ac5 there is test called: test_authonly_mrvl_all() which runs blockcipher tests with BLKCIPHER_AUTHONLY_TYPE flag. Since MRVL pmd flag was missing from pmd_mask in blockcipher_test_case_hash_test_cases table tests were not run. Moreover overall_status variable was not touched thus test suite completed without errors. > > Thanks, > Pablo > > > > > > > Signed-off-by: Tomasz Duszynski > -- - Tomasz Duszy=C5=84ski