From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: Sharing Common libs between PMDs Date: Wed, 14 Mar 2018 15:04:31 +0000 Message-ID: <20180314150431.GA7196@bricha3-MOBL.ger.corp.intel.com> References: <20180314145538.GA2482@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Liron Himi , "dev@dpdk.org" To: Jerin Jacob Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 681355681 for ; Wed, 14 Mar 2018 16:04:38 +0100 (CET) Content-Disposition: inline In-Reply-To: <20180314145538.GA2482@jerin> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 14, 2018 at 08:25:45PM +0530, Jerin Jacob wrote: > -----Original Message----- > > Date: Wed, 14 Mar 2018 09:34:40 +0000 > > From: Liron Himi > > To: "dev@dpdk.org" > > CC: Liron Himi > > Subject: [dpdk-dev] Sharing Common libs between PMDs > > > > Hi, > > > > We have several PMDs in DPDK that are using the same underlying common libraries. > > In addition, we have plans to add some new common service into DPDK that already introduces too much complexity with the way that the code is written now. > > Therefore, we would like to move all our common functions calls into one shared/common folder in DPDK and we need to find proper place for this purpose. > > > > Can you suggest on such a place? > > There was an attempt to create "driver/common" but latter the common code > for NXP HW device got moved to drivers/bus/dpaa/. Linux kernel has > something called "driver/soc", I think, "driver/soc" may be more appropriate. > > Currently DPDK's driver build dependency is in the following order > (bus, mempool, net, crypto, event). > Other than driver/common or driver/soc, one option could be to > - Move the common code to bus or mempool > and > - Across the drivers, include the header files through CFLAGS if the common code > is in header file > http://dpdk.org/browse/dpdk/tree/drivers/event/octeontx/Makefile#n13 > Given that this seems to be a recurring problem, I think having a drivers/common folder may not be a bad thing. /Bruce