From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Freimann Subject: [PATCH 05/17] net/virtio: don't dump split virtqueue data Date: Fri, 16 Mar 2018 16:21:08 +0100 Message-ID: <20180316152120.13199-6-jfreimann@redhat.com> References: <20180316152120.13199-1-jfreimann@redhat.com> Cc: tiwei.bie@intel.com, yliu@fridaylinux.org, maxime.coquelin@redhat.com, mst@redhat.com To: dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id F1D687FC9 for ; Fri, 16 Mar 2018 16:21:42 +0100 (CET) In-Reply-To: <20180316152120.13199-1-jfreimann@redhat.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" VIRTQUEUE_DUMP access split virtqueue data which is not correct when packed virtqueues are used. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtqueue.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h index cc2e7c0..82160ca 100644 --- a/drivers/net/virtio/virtqueue.h +++ b/drivers/net/virtio/virtqueue.h @@ -359,7 +359,9 @@ struct virtio_tx_region { } #ifdef RTE_LIBRTE_VIRTIO_DEBUG_DUMP -#define VIRTQUEUE_DUMP(vq) do { \ +#define VIRTQUEUE_DUMP(vq) \ + do { \ + if (vtpci_packed_queue((vq)->hw)) break; \ uint16_t used_idx, nused; \ used_idx = (vq)->vq_ring.used->idx; \ nused = (uint16_t)(used_idx - (vq)->vq_used_cons_idx); \ -- 1.8.3.1