From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH] event/sw: add unlikely branch predict
Date: Tue, 20 Mar 2018 11:09:41 +0530
Message-ID: <20180320053940.GA6251@jerin>
References: <1519762085-77659-1-git-send-email-vipin.varghese@intel.com>
 <39dc23d4-bac3-7571-eaa8-a05c9f793efc@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Vipin Varghese <vipin.varghese@intel.com>, dev@dpdk.org,
 harry.van.haaren@intel.com
To: "Laatz, Kevin" <kevin.laatz@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam03on0080.outbound.protection.outlook.com [104.47.42.80])
 by dpdk.org (Postfix) with ESMTP id CB9775F1A
 for <dev@dpdk.org>; Tue, 20 Mar 2018 06:40:01 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <39dc23d4-bac3-7571-eaa8-a05c9f793efc@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Wed, 14 Mar 2018 13:06:35 +0000
> From: "Laatz, Kevin" <kevin.laatz@intel.com>
> To: Vipin Varghese <vipin.varghese@intel.com>
> CC: dev@dpdk.org, harry.van.haaren@intel.com
> Subject: Re: [dpdk-dev] [PATCH] event/sw: add unlikely branch predict
> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
>  Thunderbird/52.6.0
> 
> 
> On 27/02/2018 20:08, Vipin Varghese wrote:
> > For most run cases 'sw->started' holds true. Adding a branch prediction
> > suggestion to compiler helps as this is first conditional check just
> > after entering the function.
> > 
> > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> > ---
> >   drivers/event/sw/sw_evdev_scheduler.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/event/sw/sw_evdev_scheduler.c b/drivers/event/sw/sw_evdev_scheduler.c
> > index 3106eb3..17bd4c0 100644
> > --- a/drivers/event/sw/sw_evdev_scheduler.c
> > +++ b/drivers/event/sw/sw_evdev_scheduler.c
> > @@ -508,7 +508,7 @@ sw_event_schedule(struct rte_eventdev *dev)
> >   	uint32_t i;
> >   	sw->sched_called++;
> > -	if (!sw->started)
> > +	if (unlikely(!sw->started))
> >   		return;
> >   	do {
> 
> Acked-by: Kevin Laatz <kevin.laatz@intel.com>

Applied to dpdk-next-eventdev/master. Thanks.