From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH v2] event/sw: perform partial burst enqueues Date: Tue, 20 Mar 2018 12:31:20 +0530 Message-ID: <20180320070119.GA31671@jerin> References: <1520549742-12893-1-git-send-email-gage.eads@intel.com> <1520866522-13942-1-git-send-email-gage.eads@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Eads, Gage" , "dev@dpdk.org" To: "Van Haaren, Harry" Return-path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0052.outbound.protection.outlook.com [104.47.32.52]) by dpdk.org (Postfix) with ESMTP id D7E072BF1 for ; Tue, 20 Mar 2018 08:01:38 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Tue, 13 Mar 2018 14:08:20 +0000 > From: "Van Haaren, Harry" > To: "Eads, Gage" , "dev@dpdk.org" > CC: "jerin.jacob@caviumnetworks.com" > Subject: RE: [PATCH v2] event/sw: perform partial burst enqueues > > > From: Eads, Gage > > Sent: Monday, March 12, 2018 2:55 PM > > To: dev@dpdk.org > > Cc: jerin.jacob@caviumnetworks.com; Van Haaren, Harry > > > > Subject: [PATCH v2] event/sw: perform partial burst enqueues > > > > Previously, the sw PMD would enqueue either all or no events, depending on > > if enough inflight credits were available for the new events in the burst. > > If a port is enqueueing a large burst (i.e. a multiple of the credit update > > quanta), this can result in suboptimal performance, and requires an > > understanding of the sw PMD implementation (in particular, its credit > > scheme) to tune an application's burst size. > > > > This affects software that enqueues large bursts of new events, such as the > > ethernet event adapter which uses a 128-deep event buffer, when the input > > packet rate is sufficiently high. > > > > This change makes the sw PMD enqueue as many events as it has credits, if > > there are any new events in the burst. > > > > Signed-off-by: Gage Eads > > > Agree that making forward progress by enqueuing what we have credits for > makes sense for the application. > > No performance degradation here, thanks for the patch: > > Acked-by: Harry van Haaren Applied to dpdk-next-eventdev/master. Thanks.