From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: Re: [PATCH 1/2] drivers: add common folder
Date: Tue, 20 Mar 2018 20:08:43 +0530
Message-ID: <20180320143842.GA15117@ltp-pvn>
References: <20180319092726.10153-1-pbhagavatula@caviumnetworks.com>
 <CAJ5mUsUE9VSsUvE_R7Tfcnfc3MTuOi0PT=tMuvd5qRAMOf-6RA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Shreyansh Jain <shreyansh.jain@nxp.com>, jerin.jacob@caviumnetworks.com,
 lironh@marvell.com, Bruce Richardson <bruce.richardson@intel.com>,
 fiona.trahe@intel.com, Hemant Agrawal <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam01on0064.outbound.protection.outlook.com [104.47.34.64])
 by dpdk.org (Postfix) with ESMTP id 5D0971F1C
 for <dev@dpdk.org>; Tue, 20 Mar 2018 15:38:59 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <CAJ5mUsUE9VSsUvE_R7Tfcnfc3MTuOi0PT=tMuvd5qRAMOf-6RA@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Shreyansh,

On Mon, Mar 19, 2018 at 04:05:13PM +0530, Shreyansh Jain wrote:
> Hi Pavan,
>
> On Mon, Mar 19, 2018 at 2:57 PM, Pavan Nikhilesh
> <pbhagavatula@caviumnetworks.com> wrote:
> > Add driver/common folder and skeleton makefile for adding commonly used
> > functions across mempool, event and net devices.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> >  drivers/Makefile           | 14 ++++++++------
> >  drivers/common/Makefile    |  7 +++++++
> >  drivers/common/meson.build |  6 ++++++
> >  drivers/meson.build        |  9 +++++----
> >  4 files changed, 26 insertions(+), 10 deletions(-)
> >  create mode 100644 drivers/common/Makefile
> >  create mode 100644 drivers/common/meson.build
> >
> > diff --git a/drivers/Makefile b/drivers/Makefile
> > index ee65c87b0..bd83ad9f3 100644
> > --- a/drivers/Makefile
> > +++ b/drivers/Makefile
> > @@ -4,17 +4,19 @@
> >  include $(RTE_SDK)/mk/rte.vars.mk
> >
> >  DIRS-y += bus
> > +DIRS-y += common
> > +DEPDIRS-common := bus
>
> Why should common be dependent on bus? Shouldn't common be independent
> in itself?

Yup will send out v2 soon.

>
> >  DIRS-y += mempool
> > -DEPDIRS-mempool := bus
> > +DEPDIRS-mempool := bus common
> >  DIRS-y += net
> > -DEPDIRS-net := bus mempool
> > +DEPDIRS-net := bus common mempool
> >  DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += bbdev
> > -DEPDIRS-bbdev := bus mempool
> > +DEPDIRS-bbdev := bus common mempool
> >  DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto
> > -DEPDIRS-crypto := bus mempool
> > +DEPDIRS-crypto := bus common mempool
> >  DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event
> > -DEPDIRS-event := bus mempool net
> > +DEPDIRS-event := bus common mempool net
> >  DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += raw
> > -DEPDIRS-raw := bus mempool net event
> > +DEPDIRS-raw := bus common mempool net event
>
> [...]
>
> -
> Shreyansh

Thanks,
Pavan.