From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: Re: [PATCH v2 2/2] octeontx: move mbox to common folder
Date: Tue, 20 Mar 2018 21:30:40 +0530
Message-ID: <20180320160039.GA18022@ltp-pvn>
References: <20180319092726.10153-1-pbhagavatula@caviumnetworks.com>
 <20180320144046.15382-1-pbhagavatula@caviumnetworks.com>
 <20180320144046.15382-2-pbhagavatula@caviumnetworks.com>
 <10673fa8-fd41-c869-779b-c34459368508@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Hemant Agrawal <hemant.agrawal@nxp.com>, jerin.jacob@caviumnetworks.com,
 santosh.shukla@caviumnetworks.com, thomas@monjalon.net,
 anatoly.burakov@intel.com, lironh@marvell.com,
 bruce.richardson@intel.com, fiona.trahe@intel.com, shreyansh.jain@nxp.com
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0054.outbound.protection.outlook.com [104.47.41.54])
 by dpdk.org (Postfix) with ESMTP id 25BC91B19
 for <dev@dpdk.org>; Tue, 20 Mar 2018 17:00:58 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <10673fa8-fd41-c869-779b-c34459368508@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Hemant,

On Tue, Mar 20, 2018 at 08:31:42PM +0530, Hemant Agrawal wrote:
>
> HI Pavan,
>     One quick comment
>
> On 3/20/2018 8:10 PM, Pavan Nikhilesh wrote:
> > -LDLIBS += -lrte_eal -lrte_eventdev -lrte_mempool_octeontx -lrte_pmd_octeontx
> > +LDLIBS += -lrte_eal -lrte_eventdev -lrte_octeontx_common -lrte_pmd_octeontx
> Typically the naming convention for driver based libraries is
> "rte_type_specific" e.g. rte_mempool_octeontx.
> rte_octeontx_common is breaking the tradition.

Currently, meson uses that scheme where as traditional make uses
rte_mempool_octeontx style. I will change it to rte_common_octeontx for
traditional make in v3.

<meson>
config_flag_fmt = 'RTE_LIBRTE_@0@_MEMPOOL'
driver_name_fmt = 'rte_mempool_@0@'

>
> Regards,
> Hemant

Thanks,
Pavan.