From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavan Nikhilesh Subject: Re: [PATCH v2 1/2] drivers: add common folder Date: Tue, 20 Mar 2018 21:36:25 +0530 Message-ID: <20180320160624.GB18022@ltp-pvn> References: <20180319092726.10153-1-pbhagavatula@caviumnetworks.com> <20180320144046.15382-1-pbhagavatula@caviumnetworks.com> <36228538.oZjJHnOzEO@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Thomas Monjalon , jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com, anatoly.burakov@intel.com, lironh@marvell.com, bruce.richardson@intel.com, fiona.trahe@intel.com, shreyansh.jain@nxp.com, hemant.agrawal@nxp.com Return-path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0050.outbound.protection.outlook.com [104.47.34.50]) by dpdk.org (Postfix) with ESMTP id AA77B1F1C for ; Tue, 20 Mar 2018 17:06:43 +0100 (CET) Content-Disposition: inline In-Reply-To: <36228538.oZjJHnOzEO@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, On Tue, Mar 20, 2018 at 04:45:47PM +0100, Thomas Monjalon wrote: > 20/03/2018 15:40, Pavan Nikhilesh: > > Add driver/common folder and skeleton makefile for adding commonly used > > functions across mempool, event and net devices. > > I am not sure there is a real benefit of introducing such new directory. > Is it only solving the choice of where you add files used > by several drivers? > Is drivers/bus/X/ the directory of choice for platform shared files? drivers/bus doesn't seem to be a appropriate abstraction common API's used across multiple PMD's. This change is in regards with the discussion on ml: http://dpdk.org/ml/archives/dev/2018-March/092822.html drivers/common seems to be a popular opinion but maybe we could use something like drivers/SoC or if you have something in mind please suggest. Thanks, Pavan. > > >