From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 1/2] drivers: add common folder
Date: Tue, 20 Mar 2018 17:01:20 +0000
Message-ID: <20180320170120.GA4260@bricha3-MOBL.ger.corp.intel.com>
References: <20180319092726.10153-1-pbhagavatula@caviumnetworks.com>
 <20180320144046.15382-1-pbhagavatula@caviumnetworks.com>
 <36228538.oZjJHnOzEO@xps> <20180320160624.GB18022@ltp-pvn>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Thomas Monjalon <thomas@monjalon.net>, jerin.jacob@caviumnetworks.com,
 santosh.shukla@caviumnetworks.com, anatoly.burakov@intel.com,
 lironh@marvell.com, fiona.trahe@intel.com, shreyansh.jain@nxp.com,
 hemant.agrawal@nxp.com, dev@dpdk.org
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 9E4932BF2
 for <dev@dpdk.org>; Tue, 20 Mar 2018 18:01:25 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20180320160624.GB18022@ltp-pvn>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Mar 20, 2018 at 09:36:25PM +0530, Pavan Nikhilesh wrote:
> Hi Thomas,
> 
> On Tue, Mar 20, 2018 at 04:45:47PM +0100, Thomas Monjalon wrote:
> > 20/03/2018 15:40, Pavan Nikhilesh:
> > > Add driver/common folder and skeleton makefile for adding commonly
> > > used functions across mempool, event and net devices.
> >
> > I am not sure there is a real benefit of introducing such new
> > directory.  Is it only solving the choice of where you add files used
> > by several drivers?  Is drivers/bus/X/ the directory of choice for
> > platform shared files?
> 
> drivers/bus doesn't seem to be a appropriate abstraction common API's
> used across multiple PMD's.
> 
> This change is in regards with the discussion on ml:
> http://dpdk.org/ml/archives/dev/2018-March/092822.html
> 
> drivers/common seems to be a popular opinion but maybe we could use
> something like drivers/SoC or if you have something in mind please
> suggest.
> 
I think drivers/common is a better solution as it's not just platform buses
or SoC's that this occurs with. Even PCI devices can export multiple
functions, such as in the QAT case, which leads to the case where you have
shared code between different driver classes. I don't think the PCI bus
driver is a good place to put QAT shared code. :-)