From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] doc: update new ethdev offload API description Date: Wed, 21 Mar 2018 15:44:31 +0000 Message-ID: <20180321154431.GC11100@bricha3-MOBL.ger.corp.intel.com> References: <44e451f86e4582815767cf75b4e0f01f5cc60b5f.1507104596.git.shahafs@mellanox.com> <4165486.q6vGXG96hz@xps> <5699565.CqXomkVGtb@xps> <20180321152638.GA11100@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Thomas Monjalon , Ferruh Yigit , "dev@dpdk.org" , Andrew Rybchenko , John McNamara , Marko Kovacevic , "Patil@dpdk.org" , Harish , Ivan Malov To: Shahaf Shuler Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A0CA85F24 for ; Wed, 21 Mar 2018 16:44:38 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 21, 2018 at 03:29:57PM +0000, Shahaf Shuler wrote: > Wednesday, March 21, 2018 5:27 PM, Bruce Richardson > > On Wed, Mar 21, 2018 at 03:40:43PM +0100, Thomas Monjalon wrote: > > > 21/03/2018 15:28, Ferruh Yigit: > > > > On 3/21/2018 2:08 PM, Thomas Monjalon wrote: > > > > > 21/03/2018 11:54, Ferruh Yigit: > > > > >> On 3/21/2018 9:47 AM, Andrew Rybchenko wrote: > > > > >>> IMHO, it should be allowed to specify queue offloads on port level. > > > > >>> It should simply enable these offloads on all queues. Also it > > > > >>> will match dev_info [rt]x_offload_capa which include both port > > > > >>> and queue offloads. > > > > > > > Why not abandon port-level config entirely? Then you just have queue-level > > configs, with the restriction that on some NICs all queues must be configured > > the same way. It can be up to the NIC drivers - or possibly ethdev layer - to > > identify and report an error in such cases. > > I would love that. And this was part of the original proposal when we first modified the offloads API. > > However Konstantin explained to me it will not work with Intel devices. There are cases were port configuration should be set on the PF w/o any queues created to enable offload on the VF. > Apologies so, my bad for not having followed the whole discussion too closely. Never mind. I'll go back to pretending I have something meaningful to contribute on other threads instead. :-) /Bruce