From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v3] net/mlx4: support CRC strip toggling
Date: Mon, 26 Mar 2018 13:54:52 +0200
Message-ID: <20180326115452.GF4011@6wind.com>
References: <1521477410-8936-1-git-send-email-ophirmu@mellanox.com>
 <1522009169-13860-1-git-send-email-ophirmu@mellanox.com>
 <e962380a-181e-3d5e-d5c9-65f1c269e63f@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Ophir Munk <ophirmu@mellanox.com>, dev@dpdk.org,
 Thomas Monjalon <thomas@monjalon.net>, Olga Shern <olgas@mellanox.com>,
 Shahaf shuler <shahafs@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com
 [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 912235F22
 for <dev@dpdk.org>; Mon, 26 Mar 2018 13:55:06 +0200 (CEST)
Received: by mail-wr0-f196.google.com with SMTP id u46so18606091wrc.11
 for <dev@dpdk.org>; Mon, 26 Mar 2018 04:55:06 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <e962380a-181e-3d5e-d5c9-65f1c269e63f@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Mar 26, 2018 at 12:38:22PM +0100, Ferruh Yigit wrote:
> On 3/25/2018 9:19 PM, Ophir Munk wrote:
> > Previous to this commit mlx4 CRC stripping was executed by default and
> > there was no verbs API to disable it.
> 
> Are you aware of the discussion about CRC [1]? Is this patch compatible with plans?
> 
> [1]
> https://dpdk.org/dev/patchwork/patch/36415/

I wasn't aware of this notice. Looks like it makes this patch unnecessary
since mlx4 always strip by default; this patch makes it configurable at will
and only exposes the capability when HW supports its configuration (i.e. the
ability to leave CRC inside mbuf).

We'd just need mlx4 to not expose DEV_RX_OFFLOAD_CRC_STRIP at all in
mlx5_get_rx_queue_offloads() in order to fully comply.

I leave it up to you, I don't mind if we include this patch only to revert
it later when we finally get rid of DEV_RX_OFFLOAD_CRC_STRIP.

> > Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> > ---
> > v1: initial version
> > v2: following internal reviews
> > v3: following dpdk.org mailing list reviews
> 
> <...>

-- 
Adrien Mazarguil
6WIND