From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-stable] [PATCH 01/13] net/bonding: fix library
 version in meson build
Date: Tue, 27 Mar 2018 21:26:12 +0100
Message-ID: <20180327202611.GA16780@bricha3-MOBL.ger.corp.intel.com>
References: <1521545187-27096-1-git-send-email-arybchenko@solarflare.com>
 <1521545187-27096-2-git-send-email-arybchenko@solarflare.com>
 <1793816.7vs2QY3WLW@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 7BF277CFC
 for <dev@dpdk.org>; Tue, 27 Mar 2018 22:26:20 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1793816.7vs2QY3WLW@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Mar 27, 2018 at 06:43:48PM +0200, Thomas Monjalon wrote:
> > --- a/drivers/net/bonding/meson.build
> > +++ b/drivers/net/bonding/meson.build
> > @@ -2,6 +2,7 @@
> >  # Copyright(c) 2017 Intel Corporation
> >  
> >  name = 'bond' #, james bond :-)
> 
> Ah ah ah, I had missed this important comment!
> 
> Unfortunately I think the real name is "bonding".
> Does it mean the full name should be james bonding?
> 
Nope, the name of the driver when built is "bond", according to the old
build system anyway. The name of the directory is "bonding", hence the
override here.

ls x86_64-native-linuxapp-gcc/lib/librte_pmd_bond*
x86_64-native-linuxapp-gcc/lib/librte_pmd_bond.a

Ideally, I'd like to be able to get rid of that "name" parameter entirely,
if we can just rename all directories to match the driver names exactly. In
this case, if we do want the driver to be called librte_pmd_bonding.a/.so,
then we just remove this override.

/Bruce