From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: Re: [PATCH v3 2/2] octeontx: move mbox to common folder
Date: Fri, 30 Mar 2018 22:53:37 +0530
Message-ID: <20180330172336.GA3184@ltp-pvn>
References: <20180319092726.10153-1-pbhagavatula@caviumnetworks.com>
 <20180326075344.2209-1-pbhagavatula@caviumnetworks.com>
 <20180326075344.2209-2-pbhagavatula@caviumnetworks.com>
 <1810472.xOB8M7Gf6E@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>, jerin.jacob@caviumnetworks.com,
 santosh.shukla@caviumnetworks.com, anatoly.burakov@intel.com,
 lironh@marvell.com, bruce.richardson@intel.com,
 fiona.trahe@intel.com, shreyansh.jain@nxp.com, hemant.agrawal@nxp.com
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02hn0203.outbound.protection.outlook.com [104.47.38.203])
 by dpdk.org (Postfix) with ESMTP id E062D4F9A
 for <dev@dpdk.org>; Fri, 30 Mar 2018 19:24:02 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1810472.xOB8M7Gf6E@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Thomas,

Thanks for the comments, will send out v4 soon addressing the comments.
I have verified static and shared builds already and everything seems to be
good.

Pavan

On Tue, Mar 27, 2018 at 06:15:56PM +0200, Thomas Monjalon wrote:
> Hi,
>
> 26/03/2018 09:53, Pavan Nikhilesh:
> > Move commonly used functions across mempool, event and net devices to a
> > common folder in drivers.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> >  drivers/common/Makefile                            |  4 ++
> >  drivers/common/meson.build                         |  1 +
> >  drivers/common/octeontx/Makefile                   | 24 ++++++++
> >  drivers/common/octeontx/meson.build                |  6 ++
> >  .../{mempool => common}/octeontx/octeontx_mbox.c   | 65 +++++++++++++++++-----
> >  .../{mempool => common}/octeontx/octeontx_mbox.h   | 14 +++++
> >  .../octeontx/rte_common_octeontx_version.map       |  9 +++
> >  drivers/event/octeontx/Makefile                    |  4 +-
> >  drivers/event/octeontx/meson.build                 |  5 +-
> >  .../{mempool => event}/octeontx/octeontx_ssovf.c   | 20 ++++++-
> >  drivers/mempool/octeontx/Makefile                  |  5 +-
> >  drivers/mempool/octeontx/meson.build               |  6 +-
> >  drivers/mempool/octeontx/octeontx_fpavf.c          |  4 --
> >  drivers/mempool/octeontx/octeontx_pool_logs.h      |  9 ---
> >  .../octeontx/rte_mempool_octeontx_version.map      |  6 --
> >  drivers/net/octeontx/Makefile                      |  3 +-
>
> You need to update MAINTAINERS for this new directory.
>
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -217,6 +217,10 @@ endif # CONFIG_RTE_LIBRTE_DPAA_BUS
> >
> >  endif # CONFIG_RTE_LIBRTE_CRYPTODEV
> >
> > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF)$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL),yy)
> > +_LDLIBS-y += -lrte_common_octeontx
> > +endif
> > +
> >  ifeq ($(CONFIG_RTE_LIBRTE_EVENTDEV),y)
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_EVENTDEV) += -lrte_pmd_skeleton_event
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV) += -lrte_pmd_sw_event
>
> It is strange to insert common lib in the middle of PMDs after crypto
> and before eventdev, in the "static-only" section.
> I think it should be just after bus libs.
>
> Please test static and shared library compilation.
>
> Thanks
>
>