From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [Bug 22] Ixgbe driver sets RDRXCTL with the wrong
 RSCACKC and FCOE_WRFIX values
Date: Sun, 1 Apr 2018 18:29:07 -0700
Message-ID: <20180401182907.1d7aaa61@xeon-e3>
References: <bug-22-3@http.dpdk.org/tracker/>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: bugzilla@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com
 [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id DF53E2BB1
 for <dev@dpdk.org>; Mon,  2 Apr 2018 03:29:15 +0200 (CEST)
Received: by mail-pf0-f182.google.com with SMTP id h69so8473286pfe.13
 for <dev@dpdk.org>; Sun, 01 Apr 2018 18:29:15 -0700 (PDT)
In-Reply-To: <bug-22-3@http.dpdk.org/tracker/>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun, 01 Apr 2018 12:42:38 +0000
bugzilla@dpdk.org wrote:

> https://dpdk.org/tracker/show_bug.cgi?id=3D22
>=20
>             Bug ID: 22
>            Summary: Ixgbe driver sets RDRXCTL with the wrong RSCACKC and
>                     FCOE_WRFIX values
>            Product: DPDK
>            Version: unspecified
>           Hardware: All
>                 OS: All
>             Status: CONFIRMED
>           Severity: normal
>           Priority: Normal
>          Component: ethdev
>           Assignee: dev@dpdk.org
>           Reporter: solal.pirelli@gmail.com
>   Target Milestone: ---
>=20
> The Intel 82599 data sheet
> (https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/=
82599-10-gbe-controller-datasheet.pdf,
> =C2=A78.2.3.8.8) states that the RDRXCTL register's RSCACKC (bit 25) and =
FCOE_WRFIX
> (bit 26) values, while reserved, should be set to 1 by software.
>=20
> The ixgbe driver does not do that, e.g. in ixgbe_dev_rx_init
> (http://dpdk.org/browse/dpdk/tree/drivers/net/ixgbe/ixgbe_rxtx.c?h=3Dv18.=
02#n4855).

It is done elsewhere.

static int
ixgbe_set_rsc(struct rte_eth_dev *dev)
{
...

	/* Set RDRXCTL.RSCACKC bit */
	rdrxctl =3D IXGBE_READ_REG(hw, IXGBE_RDRXCTL);
	rdrxctl |=3D IXGBE_RDRXCTL_RSCACKC;
	IXGBE_WRITE_REG(hw, IXGBE_RDRXCTL, rdrxctl);