From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH v9 0/9] eventtimer: introduce event timer adapter Date: Tue, 3 Apr 2018 04:49:06 +0530 Message-ID: <20180402231906.GA31895@jerin> References: <1522358852-3630-1-git-send-email-erik.g.carrillo@intel.com> <1522697994-22515-1-git-send-email-erik.g.carrillo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: pbhagavatula@caviumnetworks.com, dev@dpdk.org, hemant.agrawal@nxp.com To: Erik Gabriel Carrillo Return-path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0063.outbound.protection.outlook.com [104.47.36.63]) by dpdk.org (Postfix) with ESMTP id 78D691B408 for ; Tue, 3 Apr 2018 01:19:24 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1522697994-22515-1-git-send-email-erik.g.carrillo@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Mon, 2 Apr 2018 14:39:45 -0500 > From: Erik Gabriel Carrillo > To: pbhagavatula@caviumnetworks.com > CC: dev@dpdk.org, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com > Subject: [PATCH v9 0/9] eventtimer: introduce event timer adapter > X-Mailer: git-send-email 1.7.10 > > This patch series contains the next iteration of the Event Timer Adapter > library, which abstracts timer mechanisms that are tightly coupled with event > devices, and extends the event based programming model so that timer > expirations are represented as an event. > > v9 > - Addressed comments on previous series from Pavan: > - Don't assume services exist in HW cases > - Adjust retry logic in a couple of tests > - Addressed comments on previous series from Jerin: > - Fix build warning > - Addressed comments on previous series from Hemant: > - Adjust copyright text 1) Please fix following check-patch warnings: ### eventtimer: introduce event timer adapter ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #273: FILE: lib/librte_eventdev/rte_event_timer_adapter.h:238: +struct rte_event_timer_adapter * __rte_experimental ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #303: FILE: lib/librte_eventdev/rte_event_timer_adapter.h:268: +struct rte_event_timer_adapter * __rte_experimenta ### eventtimer: add common code ERROR:SPACING: space required after that ',' (ctx:VxB) #113: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:28: + RTE_FMT("EVTIMER: %s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) \ ^ ERROR:SPACING: space required after that ',' (ctx:VxB) #114: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:29: + "\n", __func__, __LINE__, RTE_FMT_TAIL(__VA_ARGS__,))) ^ ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #186: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:101: +struct rte_event_timer_adapter * __rte_experimental ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #193: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:108: +struct rte_event_timer_adapter * __rte_experimental total: 4 errors, 0 warnings, 695 lines checked 2) PLEASE don't remove previous Acked-by: in the patches that you have got it. For example, PATCH v9 2/9, Already had Acked-by: from me and Hemant on License change(Which is missing in this series)