From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v9 0/9] eventtimer: introduce event timer
	adapter
Date: Tue, 3 Apr 2018 19:45:03 +0530
Message-ID: <20180403141459.GA9612@jerin>
References: <1522358852-3630-1-git-send-email-erik.g.carrillo@intel.com>
 <1522697994-22515-1-git-send-email-erik.g.carrillo@intel.com>
 <20180402231906.GA31895@jerin>
 <BE54F058557D9A4FAC1D84E2FC6D87570EE0BE35@fmsmsx115.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Carrillo, Erik G" <erik.g.carrillo@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0079.outbound.protection.outlook.com [104.47.41.79])
 by dpdk.org (Postfix) with ESMTP id 413F8728A
 for <dev@dpdk.org>; Tue,  3 Apr 2018 16:15:23 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <BE54F058557D9A4FAC1D84E2FC6D87570EE0BE35@fmsmsx115.amr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Tue, 3 Apr 2018 14:09:22 +0000
> From: "Carrillo, Erik G" <erik.g.carrillo@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> CC: "dev@dpdk.org" <dev@dpdk.org>
> Subject: RE: [PATCH v9 0/9] eventtimer: introduce event timer adapter
> 
> Hi Jerin,


Hi Carrillo,

> 
> Question in-line:
> 
> > 1) Please fix following check-patch warnings:
> > 
> > ### eventtimer: introduce event timer adapter
> > 
> > ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
> > #273: FILE: lib/librte_eventdev/rte_event_timer_adapter.h:238:
> > +struct rte_event_timer_adapter * __rte_experimental
> > 
> > ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
> > #303: FILE: lib/librte_eventdev/rte_event_timer_adapter.h:268:
> > +struct rte_event_timer_adapter * __rte_experimenta
> > 
>  
> I was aware that checkpatch was complaining here, but the style I used is 
> consistent with almost all the existing DPDK code that uses the __rte_experimental
> tag.  Should I fix the warning if the style will differ from existing code?

Probably, We could fix the checkpatch. May be for short term we could
live with those warnings.

> 
> Thanks,
> Gabriel
>