From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH] eventdev: fix incorrect MP/MC tail updates
 in rte_event_ring
Date: Wed, 4 Apr 2018 06:22:26 +0530
Message-ID: <20180404005225.GB3031@jerin>
References: <1522228611-4838-1-git-send-email-hofors@lysator.liu.se>
 <1522743543-7974-1-git-send-email-hofors@lysator.liu.se>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, bruce.richardson@intel.com
To: Mattias =?iso-8859-1?Q?R=F6nnblom?= <hofors@lysator.liu.se>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam03on0057.outbound.protection.outlook.com [104.47.42.57])
 by dpdk.org (Postfix) with ESMTP id 807A81BA46
 for <dev@dpdk.org>; Wed,  4 Apr 2018 02:52:48 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1522743543-7974-1-git-send-email-hofors@lysator.liu.se>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Tue, 3 Apr 2018 10:19:03 +0200
> From: Mattias Rönnblom <hofors@lysator.liu.se>
> To: dev@dpdk.org
> CC: jerin.jacob@caviumnetworks.com, Mattias Rönnblom
>  <hofors@lysator.liu.se>, bruce.richardson@intel.com
> Subject: [PATCH] eventdev: fix incorrect MP/MC tail updates in
>  rte_event_ring
> X-Mailer: git-send-email 2.7.4
> 
> rte_event_ring enqueue and dequeue tail updates were hardcoded for a
> SC/SP configuration.
> 
> Fixes: dc39e2f359b5 ("eventdev: add ring structure for events")
> Cc: bruce.richardson@intel.com

Bruce,

As an original author of this file, Can you review this change?

> 
> Signed-off-by: Mattias Rönnblom <hofors@lysator.liu.se>
> 
> v2:
> * Fixed issue with update_tail() parameter order.
> ---
>  lib/librte_eventdev/rte_event_ring.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_eventdev/rte_event_ring.h b/lib/librte_eventdev/rte_event_ring.h
> index 29d4228..827a320 100644
> --- a/lib/librte_eventdev/rte_event_ring.h
> +++ b/lib/librte_eventdev/rte_event_ring.h
> @@ -99,7 +99,7 @@ rte_event_ring_enqueue_burst(struct rte_event_ring *r,
>  
>  	ENQUEUE_PTRS(&r->r, &r[1], prod_head, events, n, struct rte_event);
>  
> -	update_tail(&r->r.prod, prod_head, prod_next, 1, 1);
> +	update_tail(&r->r.prod, prod_head, prod_next, r->r.prod.single, 1);
>  end:
>  	if (free_space != NULL)
>  		*free_space = free_entries - n;
> @@ -140,7 +140,7 @@ rte_event_ring_dequeue_burst(struct rte_event_ring *r,
>  
>  	DEQUEUE_PTRS(&r->r, &r[1], cons_head, events, n, struct rte_event);
>  
> -	update_tail(&r->r.cons, cons_head, cons_next, 1, 0);
> +	update_tail(&r->r.cons, cons_head, cons_next, r->r.cons.single, 0);
>  
>  end:
>  	if (available != NULL)
> -- 
> 2.7.4
>