From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: Re: [PATCH v10 3/9] eventtimer: add common code
Date: Wed, 4 Apr 2018 22:20:13 +0530
Message-ID: <20180404165012.GA21642@ltp-pvn>
References: <1522697994-22515-1-git-send-email-erik.g.carrillo@intel.com>
 <1522791863-28882-1-git-send-email-erik.g.carrillo@intel.com>
 <1522791863-28882-4-git-send-email-erik.g.carrillo@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
 jerin.jacob@caviumnetworks.com
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0042.outbound.protection.outlook.com [104.47.36.42])
 by dpdk.org (Postfix) with ESMTP id B9FB91B88A
 for <dev@dpdk.org>; Wed,  4 Apr 2018 18:50:37 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1522791863-28882-4-git-send-email-erik.g.carrillo@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Apr 03, 2018 at 04:44:17PM -0500, Erik Gabriel Carrillo wrote:
> This commit adds the logic that is shared by all event timer adapter
> drivers; the common code handles instance allocation and some
> initialization.
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
>  config/common_base                                |   1 +
>  drivers/event/sw/sw_evdev.c                       |  18 +
>  lib/librte_eventdev/Makefile                      |   2 +
>  lib/librte_eventdev/rte_event_timer_adapter.c     | 387 ++++++++++++++++++++++
>  lib/librte_eventdev/rte_event_timer_adapter_pmd.h | 114 +++++++
>  lib/librte_eventdev/rte_eventdev.c                |  22 ++
>  lib/librte_eventdev/rte_eventdev.h                |  20 ++
>  lib/librte_eventdev/rte_eventdev_pmd.h            |  35 ++
>  lib/librte_eventdev/rte_eventdev_version.map      |  20 +-
>  9 files changed, 618 insertions(+), 1 deletion(-)
>  create mode 100644 lib/librte_eventdev/rte_event_timer_adapter.c
>  create mode 100644 lib/librte_eventdev/rte_event_timer_adapter_pmd.h
>
<snip>
>  DPDK_18.02 {
> @@ -80,3 +79,22 @@ DPDK_18.05 {
>
>  	rte_event_dev_stop_flush_callback_register;
>  } DPDK_18.02;
> +
> +EXPERIMENTAL {
> +	global:
> +
> +        rte_event_timer_adapter_caps_get;

A trivial extra space issue here please remove it with that,

Acked-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>

> +	rte_event_timer_adapter_create;
> +	rte_event_timer_adapter_create_ext;
> +	rte_event_timer_adapter_free;
> +	rte_event_timer_adapter_get_info;
> +	rte_event_timer_adapter_lookup;
> +	rte_event_timer_adapter_service_id_get;
> +	rte_event_timer_adapter_start;
> +	rte_event_timer_adapter_stats_get;
> +	rte_event_timer_adapter_stats_reset;
> +	rte_event_timer_adapter_stop;
> +	rte_event_timer_arm_burst;
> +	rte_event_timer_arm_tmo_tick_burst;
> +	rte_event_timer_cancel_burst;
> +} DPDK_18.05;
> --
> 2.6.4
>