From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: Question on documentation / Mellanox ConnectX-3
Date: Thu, 5 Apr 2018 11:26:21 +0200
Message-ID: <20180405092621.GI4957@6wind.com>
References: <20180403175938.GA23889@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, Timothy Redaelli <tredaelli@redhat.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id E19901CA18
 for <dev@dpdk.org>; Thu,  5 Apr 2018 11:26:35 +0200 (CEST)
Received: by mail-wm0-f43.google.com with SMTP id x82so5040977wmg.1
 for <dev@dpdk.org>; Thu, 05 Apr 2018 02:26:35 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180403175938.GA23889@localhost.localdomain>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Apr 03, 2018 at 02:59:38PM -0300, Marcelo Ricardo Leitner wrote:
> Hi,
> 
> http://docs.openvswitch.org/en/latest/howto/dpdk/ says:
> 
> Some NICs (i.e. Mellanox ConnectX-3) have only one PCI address
> associated with multiple ports. Using a PCI device like above won’t
> work. Instead, below usage is suggested:
> 
> $ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \
>     options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55:01"
> $ ovs-vsctl add-port br0 dpdk-p1 -- set Interface dpdk-p1 type=dpdk \
>     options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55:02"
> 
> But these MACs are 7 bytes long. Seems the idea was to mention the two
> incremental MAC addresses that the ports have, and thus the ':55'
> should have been removed from there, right?
> 
> Reading the code, it doesn't seem prepared to handle the extra byte in
> any (special) way.

After a quick glance at the original patch [1], I confirm it looks like a
mistake in the OVS documentation. MAC addresses should be 6 bytes long, the
7th byte is not a workaround to identify a physical port like I initially
thought.

As you pointed out, since default MAC addresses on mlx4 ports are normally
incremental, documentation should read something like:

 $ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \
     options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55"
 $ ovs-vsctl add-port br0 dpdk-p1 -- set Interface dpdk-p1 type=dpdk \
     options:dpdk-devargs="class=eth,mac=00:11:22:33:44:56"

[1] https://github.com/openvswitch/ovs/commit/5e7588186839

-- 
Adrien Mazarguil
6WIND