From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 3/3] net/netvsc: add hyper-v netvsc network
 device
Date: Thu, 5 Apr 2018 13:59:46 -0700
Message-ID: <20180405135946.38d4c60b@xeon-e3>
References: <20180405191305.26813-1-sthemmin@microsoft.com>
 <20180405191305.26813-4-sthemmin@microsoft.com>
 <8666220.g7qk7zlF1B@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Stephen Hemminger <sthemmin@microsoft.com>, dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pl0-f65.google.com (mail-pl0-f65.google.com
 [209.85.160.65]) by dpdk.org (Postfix) with ESMTP id E916F1CD33
 for <dev@dpdk.org>; Thu,  5 Apr 2018 22:59:48 +0200 (CEST)
Received: by mail-pl0-f65.google.com with SMTP id s24-v6so20969352plq.6
 for <dev@dpdk.org>; Thu, 05 Apr 2018 13:59:48 -0700 (PDT)
In-Reply-To: <8666220.g7qk7zlF1B@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 05 Apr 2018 22:52:31 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> Hi Stephen,
> 
> Good to see there is a good progress.
> 
> This patch should add an entry in the release notes.
> But I guess it is not ready for 18.05?
> 
> 
> 05/04/2018 21:13, Stephen Hemminger:
> > +#
> > +# Compile native PMD for Hyper-V/Azure
> > +#
> > +CONFIG_RTE_LIBRTE_NETVSC_PMD=n
> > +CONFIG_RTE_LIBRTE_NETVSC_DEBUG_RX=n
> > +CONFIG_RTE_LIBRTE_NETVSC_DEBUG_TX=n
> > +CONFIG_RTE_LIBRTE_NETVSC_DEBUG_DUMP=n  
> 
> Please switch to the new dynamic logging.

It does use dynamic logging for the normal driver logs. For debug the dump
code is a config option (same as other current drivers).

> 
> 
> [...]
> > +the Data Plane Development Kit (DPDK), we provide a Netwwork Virtual  
> 
> typo: Netwwork
> 
> 
> > +The following prerequisites apply:
> > +
> > +*   Linux kernel uio_hv_generic driver that supports subchannels. This should be present in 4.17 or later.  
> 
> The DPDK policy is to wait for prerequisite be available for merging.

Does linux-next count?

> 
> 
> > --- a/drivers/net/Makefile
> > +++ b/drivers/net/Makefile
> > @@ -46,6 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD) += thunderx
> >  DIRS-$(CONFIG_RTE_LIBRTE_VDEV_NETVSC_PMD) += vdev_netvsc
> >  DIRS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio
> >  DIRS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD) += vmxnet3
> > +DIRS-$(CONFIG_RTE_LIBRTE_NETVSC_PMD) += netvsc  
> 
> Please keep the alphabetical order.

Ok