From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: [PATCH] ethdev: return diagnostic when setting MAC address Date: Fri, 6 Apr 2018 17:34:50 +0200 Message-ID: <20180406153450.lqmmg3e7zkjdsmo7@platinum> References: <20180403124103.13124-1-olivier.matz@6wind.com> <20180406152148.23270-1-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Thomas Monjalon , Ferruh Yigit , Tomasz Duszynski , Andrew Rybchenko , Adrien Mazarguil , Shreyansh Jain , Ivan Malov To: dev@dpdk.org Return-path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id BBF4A1D270 for ; Fri, 6 Apr 2018 17:34:55 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20180406152148.23270-1-olivier.matz@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 06, 2018 at 05:21:48PM +0200, Olivier Matz wrote: > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > return code is added to notify the caller (librte_ether) if an error > occurred in the PMD. > > The new default MAC address is now copied in dev->data->mac_addrs[0] > only if the operation is successful. > > The patch also updates all the PMDs accordingly. > > Signed-off-by: Olivier Matz > Signed-off-by: Ivan Malov > Acked-by: Andrew Rybchenko > Acked-by: Adrien Mazarguil > Acked-by: Shreyansh Jain Sorry, "v3" is missing in the subject. Please ignore, I'm sending it again with the proper title.