From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] build: fix default arm64 build instruction level support Date: Tue, 10 Apr 2018 15:16:48 +0100 Message-ID: <20180410141648.GA164988@bricha3-MOBL.ger.corp.intel.com> References: <20180409143946.21607-1-jerin.jacob@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, herbert.guan@arm.com, pbhagavatula@caviumnetworks.com, hemant.agrawal@nxp.com, stable@dpdk.org, jerin.jacob@caviumnetworks.com To: Jerin Jacob Return-path: Content-Disposition: inline In-Reply-To: <20180409143946.21607-1-jerin.jacob@caviumnetworks.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 09, 2018 at 08:09:46PM +0530, Jerin Jacob wrote: > The make based build system has crc+crypto instruction > support for the default arm64 build. > http://dpdk.org/browse/dpdk/tree/mk/machine/armv8a/rte.vars.mk#n31 > > This patch fixes the disparity with meson build flags for armv8. > As a bonus, This patch fixes the following errors with > ip_pipeline example application. > > Assembler messages: > Error: selected processor does not support `crc32cx w3,w3,x0' > > Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for ARM") > > Cc: herbert.guan@arm.com > Cc: pbhagavatula@caviumnetworks.com > Cc: bruce.richardson@intel.com > Cc: hemant.agrawal@nxp.com > Cc: stable@dpdk.org > > Signed-off-by: Jerin Jacob > --- Hemant, Shreyansh, Herbert, any issues with this patch on your side? Can one of you please ack it. It allows use of "-Dexamples=all" when doing cross-builds for all the different arm targets in the config dir. Without it, ip_pipeline fails to build for many of the targets. /Bruce