From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: [PATCHv2] linuxapp eal: set fd to -1 for MAP_ANONYMOUS cases Date: Thu, 12 Apr 2018 07:16:40 -0400 Message-ID: <20180412111640.8977-1-nhorman@tuxdriver.com> References: <20180402120619.30404-1-nhorman@tuxdriver.com> Cc: Neil Horman , Thomas Monjalon , Ferruh Yigit To: dev@dpdk.org Return-path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 612441BB4D for ; Thu, 12 Apr 2018 13:17:37 +0200 (CEST) In-Reply-To: <20180402120619.30404-1-nhorman@tuxdriver.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" https://dpdk.org/tracker/show_bug.cgi?id=18 Indicated that several mmap call sites in the [linux|bsd]app eal code set fd that was not -1 in their calls while using MAP_ANONYMOUS. While probably not a huge deal, the man page does say the fd should be -1 for portability, as some implementations don't ignore fd as they should for MAP_ANONYMOUS. Signed-off-by: Neil Horman CC: Thomas Monjalon CC: Ferruh Yigit --- Change notes v2) Rebased to HEAD again to adjust for patches that landed ahead of this --- lib/librte_eal/bsdapp/eal/eal_memory.c | 2 +- lib/librte_eal/linuxapp/eal/eal_memory.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/bsdapp/eal/eal_memory.c b/lib/librte_eal/bsdapp/eal/eal_memory.c index b27262c7e..a5e034789 100644 --- a/lib/librte_eal/bsdapp/eal/eal_memory.c +++ b/lib/librte_eal/bsdapp/eal/eal_memory.c @@ -70,7 +70,7 @@ rte_eal_hugepage_init(void) addr = mmap(NULL, internal_config.memory, PROT_READ | PROT_WRITE, - MAP_PRIVATE | MAP_ANONYMOUS, 0, 0); + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); if (addr == MAP_FAILED) { RTE_LOG(ERR, EAL, "%s: mmap() failed: %s\n", __func__, strerror(errno)); diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c index 7cdd3048e..b7a2e951d 100644 --- a/lib/librte_eal/linuxapp/eal/eal_memory.c +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c @@ -1329,7 +1329,7 @@ eal_legacy_hugepage_init(void) } addr = mmap(NULL, internal_config.memory, PROT_READ | PROT_WRITE, - MAP_PRIVATE | MAP_ANONYMOUS, 0, 0); + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); if (addr == MAP_FAILED) { RTE_LOG(ERR, EAL, "%s: mmap() failed: %s\n", __func__, strerror(errno)); -- 2.14.3