From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3 03/13] e1000: replace rte_panic instances
 in e1000 driver
Date: Mon, 16 Apr 2018 08:34:09 -0700
Message-ID: <20180416083409.6d4cb085@xeon-e3>
References: <1523644244-17511-1-git-send-email-arnon@qwilt.com>
 <1523644244-17511-4-git-send-email-arnon@qwilt.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com,
 declan.doherty@intel.com, jerin.jacob@caviumnetworks.com,
 bruce.richardson@intel.com, ferruh.yigit@intel.com, dev@dpdk.org
To: Arnon Warshavsky <arnon@qwilt.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com
 [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id 250FCAA90
 for <dev@dpdk.org>; Mon, 16 Apr 2018 17:34:14 +0200 (CEST)
Received: by mail-pf0-f193.google.com with SMTP id p15so10702669pff.11
 for <dev@dpdk.org>; Mon, 16 Apr 2018 08:34:14 -0700 (PDT)
In-Reply-To: <1523644244-17511-4-git-send-email-arnon@qwilt.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 13 Apr 2018 21:30:34 +0300
Arnon Warshavsky <arnon@qwilt.com> wrote:

> +	if (*vfinfo == NULL) {
> +		RTE_LOG(CRIT, PMD, "%s(): Cannot allocate memory for private "
> +				"VF data\n", __func__);
> +		return -1;
> +	}
>  
Don't split strings across lines. Checkpatch should complain about that.
It makes searching for error messages in source harder.

Instead do:
	if (!*vfinfo) {
		RTE_LOG(CRIT, PMD,
			"%s(): Cannot allocate memory for private VF data\n",
			__func__);
		return -1;
	}

Also why not use PMD_DRV_LOG() macro.