From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavan Nikhilesh Subject: Re: [PATCH] app/eventdev: fix typos in timer adapter options Date: Mon, 16 Apr 2018 15:59:47 +0530 Message-ID: <20180416102946.GA18152@ltp-pvn> References: <20180416100353.28271-1-thomas@monjalon.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com To: Thomas Monjalon Return-path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0044.outbound.protection.outlook.com [104.47.38.44]) by dpdk.org (Postfix) with ESMTP id E8FAC1200A for ; Mon, 16 Apr 2018 12:30:10 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20180416100353.28271-1-thomas@monjalon.net> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 16, 2018 at 12:03:53PM +0200, Thomas Monjalon wrote: > The options names in code and doc are not the same. > > Fixes: 98c6292105d4 ("app/eventdev: add options for event timer adapter") > Cc: pbhagavatula@caviumnetworks.com > > Signed-off-by: Thomas Monjalon > --- > app/test-eventdev/evt_options.c | 2 +- > doc/guides/tools/testeventdev.rst | 12 ++++++------ > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/app/test-eventdev/evt_options.c b/app/test-eventdev/evt_options.c > index 5f311a570..701cd4e96 100644 > --- a/app/test-eventdev/evt_options.c > +++ b/app/test-eventdev/evt_options.c > @@ -248,7 +248,7 @@ usage(char *program) > "\t burst mode.\n" > "\t--nb_timers : number of timers to arm.\n" > "\t--nb_timer_adptrs : number of timer adapters to use.\n" > - "\t--timer_tick_nsec : timer tick interval in ns.\n" > + "\t--timer_tick_ns : timer tick interval in ns.\n" > "\t--max_tmo_nsec : max timeout interval in ns.\n" > "\t--expiry_ns : event timer expiry ns.\n" > ); I think it would be better to maintain consistency across options, I will send a patch to fix it. Thanks, Pavan