From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jasvinder Singh Subject: [PATCH] examples/ip_pipeline: fix memory leak Date: Mon, 16 Apr 2018 17:03:11 +0100 Message-ID: <20180416160311.112470-1-jasvinder.singh@intel.com> Cc: cristian.dumitrescu@intel.com To: dev@dpdk.org Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id EBDF0AAF5 for ; Mon, 16 Apr 2018 18:03:13 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Close the file stream before returning from the function to avoid memory leak. Fixes: 2b82ef4861c0 ("examples/ip_pipeline: add DSCP table update command") Coverty Issue: 272605 Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index 199a31f..20fbefb 100644 --- a/examples/ip_pipeline/cli.c +++ b/examples/ip_pipeline/cli.c @@ -4158,6 +4158,7 @@ load_dscp_table(struct rte_table_action_dscp_table *dscp_table, if (parse_tokenize_string(line, tokens, &n_tokens)) { *line_number = l; + fclose(f); return -EINVAL; } @@ -4172,6 +4173,7 @@ load_dscp_table(struct rte_table_action_dscp_table *dscp_table, (tc_queue_id >= RTE_TABLE_ACTION_TC_QUEUE_MAX) || (strlen(tokens[2]) != 1)) { *line_number = l; + fclose(f); return -EINVAL; } @@ -4193,6 +4195,7 @@ load_dscp_table(struct rte_table_action_dscp_table *dscp_table, default: *line_number = l; + fclose(f); return -EINVAL; } -- 2.9.3