From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2 0/4] Hyper-V Netvsc PMD
Date: Tue, 17 Apr 2018 09:22:22 -0700
Message-ID: <20180417092222.158cb849@xeon-e3>
References: <20180416232439.8018-1-sthemmin@microsoft.com>
 <DB7PR05MB4426AA62F409236670510004C3B70@DB7PR05MB4426.eurprd05.prod.outlook.com>
 <AM4PR05MB168410834752C9C8661075E0C2B70@AM4PR05MB1684.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger
 <sthemmin@microsoft.com>, Thomas Monjalon <thomasm@mellanox.com>
To: Raslan Darawsheh <rasland@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f179.google.com (mail-pf0-f179.google.com
 [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id 9D5151AFEE
 for <dev@dpdk.org>; Tue, 17 Apr 2018 18:22:26 +0200 (CEST)
Received: by mail-pf0-f179.google.com with SMTP id j11so5840233pff.10
 for <dev@dpdk.org>; Tue, 17 Apr 2018 09:22:26 -0700 (PDT)
In-Reply-To: <AM4PR05MB168410834752C9C8661075E0C2B70@AM4PR05MB1684.eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 17 Apr 2018 09:02:45 +0000
Raslan Darawsheh <rasland@mellanox.com> wrote:

> Hi Stephan,
> 
> I've just tried to apply your patches on top of current master branch and I have the following two issues:
> 1- compilation is failing with the following error when compiling with RTE_TARGET=x86_64-native-linuxapp-gcc:
> /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_common.h:122:30: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>  #define RTE_PTR_ADD(ptr, x) ((void*)((uintptr_t)(ptr) + (x)))
>                               ^
> /root/dpdk/buildtools/pmdinfogen/pmdinfogen.c:99:9: note: in expansion of macro 'RTE_PTR_ADD'
>   return RTE_PTR_ADD(info->hdr,
>          ^
> 2- compilation is also failing with the following errors when compiling with RTE_TARGET=i686-native-linuxapp-gcc
> CC linux/vmbus_uio.o
> /root/dpdk/drivers/bus/vmbus/linux/vmbus_bus.c: In function 'rte_vmbus_map_device':
> /root/dpdk/drivers/bus/vmbus/linux/vmbus_bus.c:194:39: error: passing argument 2 of 'eal_parse_sysfs_value' from incompatible pointer type [-Werror=incompatible-pointer-types]
>    if (eal_parse_sysfs_value(filename, &res->len) < 0) {
>                                        ^
> In file included from /root/dpdk/drivers/bus/vmbus/linux/vmbus_bus.c:22:0:
> /root/dpdk/lib/librte_eal/common/eal_filesystem.h:123:5: note: expected 'long unsigned int *' but argument is of type 'uint64_t * {aka long long unsigned int *}'
>  int eal_parse_sysfs_value(const char *filename, unsigned long *val);
> 
> 
> I noticed one additional new dependency which is uuid-dev  and I think you might be missing the documentation of that.
> 
> Kindest regards,
> Raslan Darawsheh

I rebased against dpdk.org master yesterday.

What version of Gcc? I don't see this on Gcc 7.3.0 and build on 64 bit.

Will update the documentation and fix a couple of typos.