From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] eal: force gcc to inline rte_movX function
Date: Tue, 17 Apr 2018 15:57:34 +0100
Message-ID: <20180417145734.GA89464@bricha3-MOBL.ger.corp.intel.com>
References: <20180412051636.240746-1-junjie.j.chen@intel.com>
 <1852475.4XxgDvW1hG@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Junjie Chen <junjie.j.chen@intel.com>, konstantin.ananyev@intel.com,
 dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id EAA6AAAB3
 for <dev@dpdk.org>; Tue, 17 Apr 2018 16:57:39 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1852475.4XxgDvW1hG@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Apr 17, 2018 at 03:22:06PM +0200, Thomas Monjalon wrote:
> 12/04/2018 07:16, Junjie Chen:
> > From: "Chen, Junjie" <junjie.j.chen@intel.com>
> > 
> > Sometimes gcc does not inline the function despite keyword *inline*,
> > we obeserve rte_movX is not inline when doing performance profiling,
> > so use *always_inline* keyword to force gcc to inline the function.
> > 
> > Signed-off-by: Chen, Junjie <junjie.j.chen@intel.com>
> > ---
> >  .../common/include/arch/x86/rte_memcpy.h           | 22 +++++++++++-----------
> >  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> The title should start with "eal/x86:"
> Something like that:
> 	eal/x86: force inlining of memcpy sub-functions
> 
> Bruce, Konstantin, any review of the content/optimization?
> 
No objection here.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>