From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jasvinder Singh Subject: [PATCH v2] examples/ip_pipeline: fix buffer not null terminated Date: Tue, 17 Apr 2018 17:39:53 +0100 Message-ID: <20180417163953.72821-1-jasvinder.singh@intel.com> References: <20180417132825.148429-1-jasvinder.singh@intel.com> Cc: cristian.dumitrescu@intel.com, bruce.richardson@intel.com To: dev@dpdk.org Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 492AC5F29 for ; Tue, 17 Apr 2018 18:39:56 +0200 (CEST) In-Reply-To: <20180417132825.148429-1-jasvinder.singh@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The destination string may not have a null termination if the source string's length is equal to the sizeof(pipeline->name). Fix by replacing strncpy with strlcpy that guarantees NULL-termination. Coverty issue: 272606 Fixes: d75c371e9b46 ("examples/ip_pipeline: add pipeline object") Signed-off-by: Jasvinder Singh Acked-by: Bruce Richardson --- examples/ip_pipeline/pipeline.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/ip_pipeline/pipeline.c b/examples/ip_pipeline/pipeline.c index 76aa1d3..43fe867 100644 --- a/examples/ip_pipeline/pipeline.c +++ b/examples/ip_pipeline/pipeline.c @@ -9,6 +9,7 @@ #include #include +#include #include #ifdef RTE_LIBRTE_KNI #include @@ -129,7 +130,7 @@ pipeline_create(const char *name, struct pipeline_params *params) } /* Node fill in */ - strncpy(pipeline->name, name, sizeof(pipeline->name)); + strlcpy(pipeline->name, name, sizeof(pipeline->name)); pipeline->p = p; pipeline->n_ports_in = 0; pipeline->n_ports_out = 0; -- 2.9.3