From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Daley Subject: [PATCH v2] net/enic: fix uninitialized variable Date: Tue, 17 Apr 2018 17:00:20 -0700 Message-ID: <20180418000020.6229-1-johndale@cisco.com> References: <20180417235324.25315-1-johndale@cisco.com> Cc: dev@dpdk.org, John Daley To: ferruh.yigit@intel.com Return-path: Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) by dpdk.org (Postfix) with ESMTP id 219748E7E for ; Wed, 18 Apr 2018 02:00:33 +0200 (CEST) In-Reply-To: <20180417235324.25315-1-johndale@cisco.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A local variable was used without initialization and triggered a coverity issue. Is is fixed here, but there is no ill effect of not initializing the variable in this case. 'rxq_interrupt_offset' is irrelevant if 'rxq_interrupt_enable' is not set (the condition caught by coverity). Fixes: fc2c8c0668fd ("net/enic: use Tx completion index instead of messages") Coverity issue: 268314 Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- v2: fix typo drivers/net/enic/enic_main.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index 822037ce8..2a2269794 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -200,15 +200,14 @@ void enic_init_vnic_resources(struct enic *enic) unsigned int error_interrupt_enable = 1; unsigned int error_interrupt_offset = 0; unsigned int rxq_interrupt_enable = 0; - unsigned int rxq_interrupt_offset; + unsigned int rxq_interrupt_offset = ENICPMD_RXQ_INTR_OFFSET; unsigned int index = 0; unsigned int cq_idx; struct vnic_rq *data_rq; - if (enic->rte_dev->data->dev_conf.intr_conf.rxq) { + if (enic->rte_dev->data->dev_conf.intr_conf.rxq) rxq_interrupt_enable = 1; - rxq_interrupt_offset = ENICPMD_RXQ_INTR_OFFSET; - } + for (index = 0; index < enic->rq_count; index++) { cq_idx = enic_cq_rq(enic, enic_rte_rq_idx_to_sop_idx(index)); -- 2.16.2