From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v5 2/4] ethdev: introduce new tunnel VXLAN-GPE
Date: Wed, 18 Apr 2018 10:12:07 +0200
Message-ID: <20180418081207.GL4957@6wind.com>
References: <20180417150404.160990-1-xuemingl@mellanox.com>
 <20180417150404.160990-3-xuemingl@mellanox.com>
 <1541697.oJ8yBXImSN@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Xueming Li <xuemingl@mellanox.com>, dev@dpdk.org,
 Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
 Shahaf Shuler <shahafs@mellanox.com>, Olivier Matz <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f181.google.com (mail-wr0-f181.google.com
 [209.85.128.181]) by dpdk.org (Postfix) with ESMTP id B3D7F7EC8
 for <dev@dpdk.org>; Wed, 18 Apr 2018 10:12:21 +0200 (CEST)
Received: by mail-wr0-f181.google.com with SMTP id h3-v6so2234389wrh.5
 for <dev@dpdk.org>; Wed, 18 Apr 2018 01:12:21 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1541697.oJ8yBXImSN@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Apr 17, 2018 at 10:56:52PM +0200, Thomas Monjalon wrote:
> 17/04/2018 17:04, Xueming Li:
> > +struct rte_flow_item_vxlan_gpe {
> > +	uint8_t flags; /**< Normally 0x0c (I and P flags). */
> > +	uint8_t rsvd0[2]; /**< Reserved, normally 0x0000. */
> > +	uint8_t protocol; /**< Protocol type. */
> > +	uint8_t vni[3]; /**< VXLAN identifier. */
> > +	uint8_t rsvd1; /**< Reserved, normally 0x00. */
> > +};
> 
> These comments are not aligned.

Regarding this part: it's OK for rte_flow.h since it's the style used in
that file. Besides I favor it as it circumvents the entire alignemnt issue
altogether for subsequent contributions.

> > +struct vxlan_gpe_hdr {
> > +	uint8_t vx_flags;	/**< flag (8). */
> > +	uint8_t reserved[2];	/**< Reserved (16). */
> > +	uint8_t proto;		/**< next-protocol (8). */
> > +	uint32_t vx_vni;	/**< VNI (24) + Reserved (8). */
> > +} __attribute__((__packed__));
> 
> Alignment must be done with spaces.
> 
> 

-- 
Adrien Mazarguil
6WIND