From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH v4 01/16] ethdev: add error types to flow API Date: Wed, 18 Apr 2018 10:41:31 +0200 Message-ID: <20180418084131.GM4957@6wind.com> References: <20180410162022.9101-1-adrien.mazarguil@6wind.com> <20180416150525.2817-1-adrien.mazarguil@6wind.com> <20180416150525.2817-2-adrien.mazarguil@6wind.com> <0d8bec2d-b1fc-a772-83de-9b0d641ec535@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Thomas Monjalon , dev@dpdk.org To: Ferruh Yigit Return-path: Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id 8BF857CB9 for ; Wed, 18 Apr 2018 10:41:47 +0200 (CEST) Received: by mail-wr0-f169.google.com with SMTP id u11-v6so2446175wri.12 for ; Wed, 18 Apr 2018 01:41:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <0d8bec2d-b1fc-a772-83de-9b0d641ec535@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 17, 2018 at 08:37:31PM +0100, Ferruh Yigit wrote: > On 4/16/2018 5:22 PM, Adrien Mazarguil wrote: > > These enable more precise reporting of objects responsible for errors. > > > > This breaks ABI compatibility for the following public functions: > > > > - rte_flow_create() > > - rte_flow_destroy() > > - rte_flow_error_set() > > - rte_flow_flush() > > - rte_flow_isolate() > > - rte_flow_query() > > - rte_flow_validate() > > Is there a deprecation notice for this API break? A notice covering the main changes in this series (most patches have an ABI impact) was sent but not included [1]. This particular patch rides on the announced ABI breakage in order to add a relatively minor feature while there. This ABI change was implicitly needed by upcoming work for 18.05 (Xueming's RSS stuff [2][3], Declan's TEP [4], the rest is summarized by a RFC [5]) due to the necessary changes of behavior in flow rules. Note that Xueming's deprecation notice [3] alone would have triggered such an ABI change because struct rte_flow_action_rss wouldn't have been binary compatible if struct rte_eth_rss_conf was updated. This change would have propagated back to rte_flow functions manipulating them. [1] "doc: announce API changes for flow rules" http://dpdk.org/ml/archives/dev/2018-February/090988.html [2] "MLX5 tunnel Rx offloading" http://dpdk.org/ml/archives/dev/2018-February/091461.html [3] "doc: annouce ABI change for RSS configuraiton structure" http://dpdk.org/ml/archives/dev/2018-February/090127.html [4] "tunnel endpoint hw acceleration enablement" http://dpdk.org/ml/archives/dev/2017-December/084676.html [5] "Switch device offload with DPDK" http://dpdk.org/ml/archives/dev/2018-March/092513.html > > Signed-off-by: Adrien Mazarguil > > Acked-by: Andrew Rybchenko > > <...> > -- Adrien Mazarguil 6WIND