From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3 2/4] net/netvsc: add hyper-v netvsc
 network device
Date: Wed, 18 Apr 2018 09:04:20 -0700
Message-ID: <20180418090420.225b6651@xeon-e3>
References: <20180417215324.8576-1-sthemmin@microsoft.com>
 <20180417215324.8576-3-sthemmin@microsoft.com>
 <438086f5-76f4-3c72-5c2f-b54577d12af2@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f171.google.com (mail-pf0-f171.google.com
 [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id 742845F4F
 for <dev@dpdk.org>; Wed, 18 Apr 2018 18:04:23 +0200 (CEST)
Received: by mail-pf0-f171.google.com with SMTP id y69so1132593pfb.5
 for <dev@dpdk.org>; Wed, 18 Apr 2018 09:04:23 -0700 (PDT)
In-Reply-To: <438086f5-76f4-3c72-5c2f-b54577d12af2@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

 
> > +/* XXX Why is this not generic in RTE? */
> > +static int
> > +hn_dev_atomic_write_link_status(struct rte_eth_dev *dev,
> > +		struct rte_eth_link *link)
> > +{  
> 
> It is indeed generic now thanks to you :)
> Can you switch to your generic functions?

Will change in v4. This driver has been developed on older
source predating this.