From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Duszynski <tdu@semihalf.com>
Subject: Re: [PATCH] net/mvpp2: get MUSDK library path from a
	meson option
Date: Thu, 19 Apr 2018 14:06:12 +0200
Message-ID: <20180419120612.GA14506@sh>
References: <1524131138-3204-1-git-send-email-tdu@semihalf.com>
 <20180419120511.GA11352@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Tomasz Duszynski <tdu@semihalf.com>, dev@dpdk.org, dima@marvell.com,
 nsamsono@marvell.com
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f66.google.com (mail-lf0-f66.google.com
 [209.85.215.66]) by dpdk.org (Postfix) with ESMTP id D3609CFA8
 for <dev@dpdk.org>; Thu, 19 Apr 2018 14:06:13 +0200 (CEST)
Received: by mail-lf0-f66.google.com with SMTP id r125-v6so456789lfe.2
 for <dev@dpdk.org>; Thu, 19 Apr 2018 05:06:13 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180419120511.GA11352@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Apr 19, 2018 at 01:05:11PM +0100, Bruce Richardson wrote:
> On Thu, Apr 19, 2018 at 11:45:38AM +0200, Tomasz Duszynski wrote:
> > Since not cluttering environment and keeping all relevant
> > settings local to the cross build is reasonable get
> > MUSDK library installation path from a meson option.
> >
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > ---
> >  drivers/net/mvpp2/meson.build | 2 +-
> >  meson_options.txt             | 2 ++
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/mvpp2/meson.build b/drivers/net/mvpp2/meson.bu=
ild
> > index 6ea13ee..e139889 100644
> > --- a/drivers/net/mvpp2/meson.build
> > +++ b/drivers/net/mvpp2/meson.build
> > @@ -3,7 +3,7 @@
> >  # Copyright(c) 2018 Semihalf.
> >  # All rights reserved.
> >
> > -path =3D run_command('printenv', 'LIBMUSDK_PATH').stdout().strip()
> > +path =3D get_option('lib_musdk_dir')
> >  lib_dir =3D path + '/lib'
> >  inc_dir =3D path + '/include'
> >
> > diff --git a/meson_options.txt b/meson_options.txt
> > index 1a674aa..c843278 100644
> > --- a/meson_options.txt
> > +++ b/meson_options.txt
> > @@ -8,6 +8,8 @@ option('include_subdir_arch', type: 'string', value: '',
> >  	description: 'subdirectory where to install arch-dependent headers')
> >  option('kernel_dir', type: 'string', value: '',
> >  	description: 'path to the kernel for building kernel modules')
> > +option('lib_musdk_dir', type: 'string', value: '',
> > +	description: 'path to the MUSDK library installation directory')
> >  option('machine', type: 'string', value: 'native',
> >  	description: 'set the target machine type')
> >  option('max_lcores', type: 'string', value: '128',
> > --
> > 2.7.4
>
> Looks good. Are you ok with me just squashing this into the original comm=
it?
>
> /Bruce
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Sure, thanks.

--
- Tomasz Duszy=C5=84ski