From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 1/2] net/dpaa: non supported offloads are
 ignored with warning
Date: Fri, 20 Apr 2018 08:20:45 -0700
Message-ID: <20180420082045.065283f1@xeon-e3>
References: <20180420104541.21987-1-sunil.kori@nxp.com>
 <20180420104541.21987-2-sunil.kori@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <hemant.agrawal@nxp.com>, <shreyansh.jain@nxp.com>
To: Sunil Kumar Kori <sunil.kori@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f174.google.com (mail-pf0-f174.google.com
 [209.85.192.174]) by dpdk.org (Postfix) with ESMTP id 2381A7ECB
 for <dev@dpdk.org>; Fri, 20 Apr 2018 17:20:49 +0200 (CEST)
Received: by mail-pf0-f174.google.com with SMTP id h69so4437114pfe.13
 for <dev@dpdk.org>; Fri, 20 Apr 2018 08:20:49 -0700 (PDT)
In-Reply-To: <20180420104541.21987-2-sunil.kori@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 20 Apr 2018 16:15:40 +0530
Sunil Kumar Kori <sunil.kori@nxp.com> wrote:

>  	dpaa_eth_dev_info(dev, &dev_info);
>  	if (((~(dev_info.rx_offload_capa) & rx_offloads) != 0)) {
> -		DPAA_PMD_ERR("Some Rx offloads are not supported "
> +		DPAA_PMD_WARN("Some Rx offloads are not supported "
>  			"requested 0x%" PRIx64 " supported 0x%" PRIx64,

The if statement has more parens than necessary.

Please don't break error messages across lines, it is better to have a long source
line since it allows users to use tools like grep to search for error messages.