From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v4 1/6] ethdev: Add tunnel encap/decap actions
Date: Mon, 23 Apr 2018 13:49:07 +0200
Message-ID: <20180423114907.GN4957@6wind.com>
References: <1523017443-12414-1-git-send-email-declan.doherty@intel.com>
 <20180418210423.13847-1-declan.doherty@intel.com>
 <20180418210423.13847-2-declan.doherty@intel.com>
 <20180419130307.GY4957@6wind.com>
 <DB7PR05MB44264B952C88BD075D857369C3890@DB7PR05MB4426.eurprd05.prod.outlook.com>
 <0aff3015-b8f7-2abe-984c-f8f4ff2251d6@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Shahaf Shuler <shahafs@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Alex Rosenbaum <alexr@mellanox.com>, Ferruh Yigit <ferruh.yigit@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>, Qi Zhang <qi.z.zhang@intel.com>,
 Alejandro Lucero <alejandro.lucero@netronome.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>,
 Remy Horton <remy.horton@intel.com>,
 John McNamara <john.mcnamara@intel.com>, Rony Efraim <ronye@mellanox.com>,
 Jingjing Wu <jingjing.wu@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Vincent Jardin <vincent.jardin@6wind.com>,
 Yuanhan Liu <yliu@fridaylinux.org>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Zhihong Wang <zhihong.wang@intel.com>
To: "Doherty, Declan" <declan.doherty@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com
 [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id 611D12583
 for <dev@dpdk.org>; Mon, 23 Apr 2018 13:49:22 +0200 (CEST)
Received: by mail-wr0-f172.google.com with SMTP id d1-v6so40370927wrj.13
 for <dev@dpdk.org>; Mon, 23 Apr 2018 04:49:22 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <0aff3015-b8f7-2abe-984c-f8f4ff2251d6@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Apr 23, 2018 at 12:17:09PM +0100, Doherty, Declan wrote:
> On 23/04/2018 12:00 PM, Shahaf Shuler wrote:
> > Thursday, April 19, 2018 4:03 PM, Adrien Mazarguil:
> > > Subject: Re: [dpdk-dev] [PATCH v4 1/6] ethdev: Add tunnel encap/decap
> > > actions
> > > 
> > > On Wed, Apr 18, 2018 at 10:04:18PM +0100, Declan Doherty wrote:
> > 
> > [...]
> > 
> > > 
> > > I'm still unsure about the definition involving a list of items. I imagined
> > > these actions even less generic than that. How about tagging them
> > > EXPERIMENTAL until sorted out through the first PMD implementation?
> > 
> > I think every new API should be marked as experimental. At least for one release.
> > Here in specific, because there is no actual implementation of those APIs in any of the drivers.
> > 
> 
> On this, since these are just new structures to use with existing APIs is
> using the following tag in the doxygen comments sufficient?
> 
> /**
>  * @warning
>  * @b EXPERIMENTAL: this structure may change without prior notice
>  */

Looks good to me. I did not realize we already had such a thing in DPDK
(eventdev).

> > > (We could even provide forward declarations only to prevent applications
> > > from using them in the meantime.)

-- 
Adrien Mazarguil
6WIND