From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v6 01/11] crypto/dpaa: replace rte_panic
 instances in crypto/dpaa driver
Date: Tue, 24 Apr 2018 08:00:32 -0700
Message-ID: <20180424080032.161d08b9@xeon-e3>
References: <1524552123-31378-1-git-send-email-arnon@qwilt.com>
 <1524552123-31378-2-git-send-email-arnon@qwilt.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com,
 declan.doherty@intel.com, jerin.jacob@caviumnetworks.com,
 bruce.richardson@intel.com, ferruh.yigit@intel.com, dev@dpdk.org
To: Arnon Warshavsky <arnon@qwilt.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65])
 by dpdk.org (Postfix) with ESMTP id B631E4F90
 for <dev@dpdk.org>; Tue, 24 Apr 2018 17:00:36 +0200 (CEST)
Received: by mail-pg0-f65.google.com with SMTP id 82so1230181pge.11
 for <dev@dpdk.org>; Tue, 24 Apr 2018 08:00:36 -0700 (PDT)
In-Reply-To: <1524552123-31378-2-git-send-email-arnon@qwilt.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 24 Apr 2018 09:41:53 +0300
Arnon Warshavsky <arnon@qwilt.com> wrote:

> +		if (cryptodev->data->dev_private == NULL) {
> +			RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone for private device data",
> +			__func__);

dpaa2_sec is already doing private log type, via DPAA2_SEC_LOG macro.

You should go through your patch and make sure there are as few direct calls
to RTE_LOG as possible.