From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v7 02/11] bond: replace rte_panic instances in bonding driver Date: Tue, 24 Apr 2018 15:51:46 -0700 Message-ID: <20180424155146.35f5031f@xeon-e3> References: <1524608213-2080-1-git-send-email-arnon@qwilt.com> <1524608213-2080-3-git-send-email-arnon@qwilt.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, dev@dpdk.org To: Arnon Warshavsky Return-path: Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id 5D6504C95 for ; Wed, 25 Apr 2018 00:51:49 +0200 (CEST) Received: by mail-pf0-f196.google.com with SMTP id a14so2973687pfi.1 for ; Tue, 24 Apr 2018 15:51:49 -0700 (PDT) In-Reply-To: <1524608213-2080-3-git-send-email-arnon@qwilt.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 25 Apr 2018 01:16:44 +0300 Arnon Warshavsky wrote: > replace panic calls with log and return value. > Local functions to this file, > changing from void to int are non-abi-breaking > > Signed-off-by: Arnon Warshavsky > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +- > drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++++++++++++++--------- > drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2 +- > drivers/net/bonding/rte_eth_bond_api.c | 22 ++++++++++++----- > drivers/net/bonding/rte_eth_bond_pmd.c | 9 ++++--- > drivers/net/bonding/rte_eth_bond_private.h | 2 +- > 6 files changed, 43 insertions(+), 23 deletions(-) > > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > index a78f3a2..a19fb40 100644 > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > @@ -2884,7 +2884,7 @@ struct rte_security_ops dpaa2_sec_security_ops = { > rte_socket_id()); > > if (cryptodev->data->dev_private == NULL) { > - DPAA_SEC_ERR("%s() Cannot allocate memzone for private device data", > + DPAA2_SEC_ERR("%s() Cannot allocate memzone for private device data", > __func__); > return -ENOMEM; You mixed dpaa2 with bonding in this set.