From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v7 11/11] devtools: prevent new instances of
 rte_panic and rte_exit
Date: Tue, 24 Apr 2018 16:15:46 -0700
Message-ID: <20180424161546.43bc1ebe@xeon-e3>
References: <1524608213-2080-1-git-send-email-arnon@qwilt.com>
 <1524608213-2080-12-git-send-email-arnon@qwilt.com>
 <20180424155253.7a11479f@xeon-e3> <3515084.lgnKaFBshB@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Arnon Warshavsky <arnon@qwilt.com>, anatoly.burakov@intel.com,
 wenzhuo.lu@intel.com, declan.doherty@intel.com,
 jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com,
 ferruh.yigit@intel.com, dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com
 [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id 89D5A4C6F
 for <dev@dpdk.org>; Wed, 25 Apr 2018 01:15:50 +0200 (CEST)
Received: by mail-pf0-f193.google.com with SMTP id f15so13530324pfn.0
 for <dev@dpdk.org>; Tue, 24 Apr 2018 16:15:50 -0700 (PDT)
In-Reply-To: <3515084.lgnKaFBshB@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 25 Apr 2018 01:03:20 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> 25/04/2018 00:52, Stephen Hemminger:
> > On Wed, 25 Apr 2018 01:16:53 +0300
> > Arnon Warshavsky <arnon@qwilt.com> wrote:
> >   
> > > This patch adds a new function that is called
> > > per every checked patch,
> > > and alerts for new instances of rte_panic/rte_exit.
> > > The check excludes comments, and alerts in the case
> > > of a positive balance between additions and removals.
> > > 
> > > Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>  
> > 
> > Why not just mark the functions as deprecated with compiler attribute.  
> 
> No, the applications can use these functions.

Yeah, fighting against that would be hard. They always seemed like internal
functions.