From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH] eal: shut up warning about master lcore Date: Wed, 25 Apr 2018 17:48:39 -0700 Message-ID: <20180426004839.4097-1-sthemmin@microsoft.com> Cc: dev@dpdk.org, Stephen Hemminger , Stephen Hemminger To: anatoly.burakov@intel.com Return-path: Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by dpdk.org (Postfix) with ESMTP id F12436841 for ; Thu, 26 Apr 2018 02:48:43 +0200 (CEST) Received: by mail-pf0-f195.google.com with SMTP id g14so16705949pfh.3 for ; Wed, 25 Apr 2018 17:48:43 -0700 (PDT) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This message looks suspicious and seen on healthy testpmd. EAL: WARNING: Master core has no memory on local socket! The message is wrong: the master lcore is 0 and its socket is 0 and there are multiple available memory segments on socket 0. At that point in the startup process, the count value is zero, meaning they are not used yet so the check_socket gets confused. Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") Signed-off-by: Stephen Hemminger --- lib/librte_eal/linuxapp/eal/eal.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 200e879d241a..e2c0bd649429 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_eal/linuxapp/eal/eal.c @@ -645,10 +645,7 @@ check_socket(const struct rte_memseg_list *msl, void *arg) { int *socket_id = arg; - if (msl->socket_id == *socket_id && msl->memseg_arr.count != 0) - return 1; - - return 0; + return *socket_id == msl->socket_id; } static void -- 2.17.0