From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] lcore: make semantics of lcore role function
 more intuitive
Date: Thu, 26 Apr 2018 08:38:42 -0700
Message-ID: <20180426083842.5fc6c83c@xeon-e3>
References: <b25e9076c53da76cc658363bab8de60ebd69d10b.1524745985.git.anatoly.burakov@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Neil Horman <nhorman@tuxdriver.com>, John McNamara
 <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>,
 Robert Sanford <rsanford@akamai.com>, thomas@monjalon.net,
 erik.g.carrillo@intel.com, olivier.matz@6wind.com
To: Anatoly Burakov <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com
 [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id B36168BA7
 for <dev@dpdk.org>; Thu, 26 Apr 2018 17:38:45 +0200 (CEST)
Received: by mail-pf0-f196.google.com with SMTP id f15so18703013pfn.0
 for <dev@dpdk.org>; Thu, 26 Apr 2018 08:38:45 -0700 (PDT)
In-Reply-To: <b25e9076c53da76cc658363bab8de60ebd69d10b.1524745985.git.anatoly.burakov@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 26 Apr 2018 14:42:31 +0100
Anatoly Burakov <anatoly.burakov@intel.com> wrote:

> rte_lcore_has_role() returns 0 if role of lcore matches requested
> role. The return value of the API is confusing, and this is a known
> problem with a deprecation notice announcing the change to more
> intuitive semantics:
> 
> Commit 064518f68d48 ("doc: announce EAL API change to lcore role function")
> Cc: erik.g.carrillo@intel.com
> 
> Implement changes announced in the deprecation notice, and remove it.
> Also, fix usages of this API to reflect the change. Control thread patches
> expected new behavior and were broken before, now they are fixed as well.
> 
> Fixes: d651ee4919cd ("eal: set affinity for control threads")
> Cc: olivier.matz@6wind.com
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

It would make more sense if rte_lcore_has_role returned a bool