From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4 1/4] Add RIB library
Date: Thu, 26 Apr 2018 15:17:10 -0700
Message-ID: <20180426151710.58b3028a@xeon-e3>
References: <1524780214-23196-1-git-send-email-medvedkinv@gmail.com>
 <1524780214-23196-2-git-send-email-medvedkinv@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, bruce.richardson@intel.com, thomas@monjalon.net,
 cristian.dumitrescu@intel.com
To: Medvedkin Vladimir <medvedkinv@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com
 [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id C11C47EE3
 for <dev@dpdk.org>; Fri, 27 Apr 2018 00:17:13 +0200 (CEST)
Received: by mail-pf0-f193.google.com with SMTP id f189so10333161pfa.7
 for <dev@dpdk.org>; Thu, 26 Apr 2018 15:17:13 -0700 (PDT)
In-Reply-To: <1524780214-23196-2-git-send-email-medvedkinv@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 27 Apr 2018 01:03:31 +0300
Medvedkin Vladimir <medvedkinv@gmail.com> wrote:

> +static inline int __attribute__((pure))
> +rte_rib_is_right_node(struct rte_rib_node *node)
> +{
> +	return (node->parent->right == node);
> +}
> +

Minor nit (repeated in several places).
DPDK uses Linux (not BSD) style where extra paranthesis are not needed on return statement.