From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [v2,1/6] eventdev: introduce event crypto adapter Date: Thu, 3 May 2018 14:32:43 +0530 Message-ID: <20180503090242.GA10158@jerin> References: <1524573807-168522-1-git-send-email-abhinandan.gujjar@intel.com> <1524573807-168522-2-git-send-email-abhinandan.gujjar@intel.com> <20180429160835.GA11546@jerin> <5612CB344B05EE4F95FC5B729939F78070701D35@PGSMSX102.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "hemant.agrawal@nxp.com" , "akhil.goyal@nxp.com" , "dev@dpdk.org" , "Vangati, Narender" , "Rao, Nikhil" , "Eads, Gage" To: "Gujjar, Abhinandan S" Return-path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0089.outbound.protection.outlook.com [104.47.42.89]) by dpdk.org (Postfix) with ESMTP id A51512BAA for ; Thu, 3 May 2018 11:03:07 +0200 (CEST) Content-Disposition: inline In-Reply-To: <5612CB344B05EE4F95FC5B729939F78070701D35@PGSMSX102.gar.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Thu, 3 May 2018 06:03:01 +0000 > From: "Gujjar, Abhinandan S" > To: Jerin Jacob > CC: "hemant.agrawal@nxp.com" , > "akhil.goyal@nxp.com" , "dev@dpdk.org" > , "Vangati, Narender" , "Rao, > Nikhil" , "Eads, Gage" > Subject: RE: [v2,1/6] eventdev: introduce event crypto adapter > > > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Sunday, April 29, 2018 9:39 PM > > To: Gujjar, Abhinandan S > > Cc: hemant.agrawal@nxp.com; akhil.goyal@nxp.com; dev@dpdk.org; Vangati, > > Narender ; Rao, Nikhil ; > > Eads, Gage > > Subject: Re: [v2,1/6] eventdev: introduce event crypto adapter > > > > -----Original Message----- > > > Date: Tue, 24 Apr 2018 18:13:22 +0530 > > > From: Abhinandan Gujjar > > > To: jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, > > > akhil.goyal@nxp.com, dev@dpdk.org > > > CC: narender.vangati@intel.com, abhinandan.gujjar@intel.com, > > > nikhil.rao@intel.com, gage.eads@intel.com > > > Subject: [v2,1/6] eventdev: introduce event crypto adapter > > > X-Mailer: git-send-email 1.9.1 > > > > > > Signed-off-by: Abhinandan Gujjar > > > Signed-off-by: Nikhil Rao > > > Signed-off-by: Gage Eads > > > --- > > > lib/librte_eventdev/rte_event_crypto_adapter.h | 532 > > > +++++++++++++++++++++++++ > > > 1 file changed, 532 insertions(+) > > > create mode 100644 lib/librte_eventdev/rte_event_crypto_adapter.h > > > > > > diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.h > > > b/lib/librte_eventdev/rte_event_crypto_adapter.h > > > new file mode 100644 > > > index 0000000..aa4f32c > > > --- /dev/null > > > +++ b/lib/librte_eventdev/rte_event_crypto_adapter.h > > > @@ -0,0 +1,532 @@ > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > + * Copyright(c) 2017-2018 Intel Corporation */ > > > + > > > +#ifndef _RTE_EVENT_CRYPTO_ADAPTER_ > > > +#define _RTE_EVENT_CRYPTO_ADAPTER_ > > > > Please reword if it makes sense. > It is to the adapter through eventdev. > May be elaborating little more something like, application gets crypto adapter's > event port by rte_event_crypto_adapter_event_port_get() API. > Application links it's event queue to this event port and starts enqueuing crypto > operations as events. Adapter dequeue these events and submit the crypto operations > to the cryptodev. > > Does this make sense? Yes > > > + RTE_EVENT_CRYPTO_ADAPTER_DEQ_ONLY = 1, > > > > Why to mark it as explicit '1' ? > Nothing specific. Have 0 & 1? Let have 0 then so that enum you don't need to specify '0' explicit as enum starts from 0 Thanks for the comments. Looks like we have sorted out all the issues.