From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [v3,
	2/5] eventdev: add APIs and PMD callbacks for crypto adapter
Date: Mon, 7 May 2018 15:22:39 +0530
Message-ID: <20180507095238.GA9245@jerin>
References: <1525546030-11204-1-git-send-email-abhinandan.gujjar@intel.com>
 <1525546030-11204-3-git-send-email-abhinandan.gujjar@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: hemant.agrawal@nxp.com, akhil.goyal@nxp.com, dev@dpdk.org,
 narender.vangati@intel.com, nikhil.rao@intel.com, gage.eads@intel.com
To: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02on0076.outbound.protection.outlook.com [104.47.38.76])
 by dpdk.org (Postfix) with ESMTP id 0CCB52BA7
 for <dev@dpdk.org>; Mon,  7 May 2018 11:53:00 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1525546030-11204-3-git-send-email-abhinandan.gujjar@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Sun, 6 May 2018 00:17:07 +0530
> From: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> To: jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com,
>  akhil.goyal@nxp.com, dev@dpdk.org
> CC: narender.vangati@intel.com, abhinandan.gujjar@intel.com,
>  nikhil.rao@intel.com, gage.eads@intel.com
> Subject: [v3,2/5] eventdev: add APIs and PMD callbacks for crypto adapter
> X-Mailer: git-send-email 1.9.1
> 
> Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> ---
>  drivers/event/sw/sw_evdev.c            |  13 +++
>  lib/librte_eventdev/rte_eventdev.c     |  25 +++++
>  lib/librte_eventdev/rte_eventdev.h     |  54 ++++++++++
>  lib/librte_eventdev/rte_eventdev_pmd.h | 187 +++++++++++++++++++++++++++++++++
>  4 files changed, 279 insertions(+)
> 
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -8,6 +8,8 @@
>  #ifndef _RTE_EVENTDEV_H_
>  #define _RTE_EVENTDEV_H_
>  
> +#include <rte_compat.h>

Why rte_compat.h ? Is it by mistake? I could compile without this change.

> +
>  /**
>   * @file
>   *
> @@ -1135,6 +1137,58 @@ struct rte_event {
>  int __rte_experimental
>  rte_event_timer_adapter_caps_get(uint8_t dev_id, uint32_t *caps);
>  
> @@ -70,6 +70,9 @@
>  		((RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID) | \
>  			(RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ))
>  
> +#define RTE_EVENT_CRYPTO_ADAPTER_SW_CAP \
> +		RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA

I thought, SW driver has support for RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND.
If not, please ignore this comment.


With above changes:
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>