From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Duszynski Subject: Re: [PATCH v2] crypto/mrvl: rename PMD to mvsam Date: Tue, 8 May 2018 08:13:23 +0200 Message-ID: <20180508061323.GA8117@sh> References: <1524763320-29946-1-git-send-email-tdu@semihalf.com> <1524813326-31233-1-git-send-email-tdu@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Tomasz Duszynski , "dev@dpdk.org" , "dima@marvell.com" , Natalie Samsonov To: "De Lara Guarch, Pablo" Return-path: Received: from mail-lf0-f50.google.com (mail-lf0-f50.google.com [209.85.215.50]) by dpdk.org (Postfix) with ESMTP id 1842F58FA for ; Tue, 8 May 2018 08:13:26 +0200 (CEST) Received: by mail-lf0-f50.google.com with SMTP id g12-v6so44063777lfb.10 for ; Mon, 07 May 2018 23:13:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 07, 2018 at 02:19:42PM +0000, De Lara Guarch, Pablo wrote: > > > > -----Original Message----- > > From: Tomasz Duszynski [mailto:tdu@semihalf.com] > > Sent: Friday, April 27, 2018 8:15 AM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; > > dima@marvell.com; Tomasz Duszynski ; Natalie Samsonov > > > > Subject: [PATCH v2] crypto/mrvl: rename PMD to mvsam > > > > Picking a company stock ticker for a PMD name might not be a best appro= ach in > > a long run since name is too generic. > > > > This patch addresses that and renames mrvl to mvsam. > > > > Signed-off-by: Natalie Samsonov > > Signed-off-by: Tomasz Duszynski > > --- > > ... > > > --- a/test/test/test_cryptodev.h > > +++ b/test/test/test_cryptodev.h > > @@ -61,7 +61,7 @@ > > #define CRYPTODEV_NAME_DPAA_SEC_PMD crypto_dpaa_sec > > #define CRYPTODEV_NAME_DPAA2_SEC_PMD crypto_dpaa2_sec > > #define CRYPTODEV_NAME_SCHEDULER_PMD crypto_scheduler > > -#define CRYPTODEV_NAME_MRVL_PMD crypto_mrvl > > +#define CRYPTODEV_NAME_MRVL_PMD crypto_mvsam > > I think it would be better if you modify the macro names in the test app,= to be MVSAM. I did not change these intentionally since the same naming is used througho= ut the PMD itself, so to me it looked more consistent to have it this way. Additionally I wanted to avoid as much noise generated by renames as possible. Besides that, no strong opinions and I am okay with v3. > > > #define CRYPTODEV_NAME_CCP_PMD crypto_ccp > > #define CRYPTODEV_NAME_VIRTIO_PMD crypto_virtio > > > > -- > > 2.7.4 > -- - Tomasz Duszy=C5=84ski