From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH 05/18] drivers: net: nfp: nfpcore: fix
 strncpy misuse
Date: Tue, 8 May 2018 10:03:11 +0100
Message-ID: <20180508090310.GD20636@bricha3-MOBL.ger.corp.intel.com>
References: <152575364588.56689.3300796065057551728.stgit@localhost.localdomain>
 <152575379320.56689.8382051384798098704.stgit@localhost.localdomain>
 <20180508085835.GB20636@bricha3-MOBL.ger.corp.intel.com>
 <ae8f8a5a-17c8-64a7-ff5f-9efc7785bf29@warmcat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Andy Green <andy@warmcat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 91E695F65
 for <dev@dpdk.org>; Tue,  8 May 2018 11:03:15 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <ae8f8a5a-17c8-64a7-ff5f-9efc7785bf29@warmcat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, May 08, 2018 at 05:00:21PM +0800, Andy Green wrote:
> 
> 
> On 05/08/2018 04:58 PM, Bruce Richardson wrote:
> > On Tue, May 08, 2018 at 12:29:53PM +0800, Andy Green wrote:
> > > 
> > > ---
> > >   drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |    3 ++-
> > >   1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> > > index 4e6c66624..9f6704a7f 100644
> > > --- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> > > +++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> > > @@ -846,7 +846,8 @@ nfp6000_init(struct nfp_cpp *cpp, const char *devname)
> > >   	memset(desc->busdev, 0, BUSDEV_SZ);
> > > -	strncpy(desc->busdev, devname, strlen(devname));
> > > +	strncpy(desc->busdev, devname, sizeof(desc->busdev) - 1);
> > > +	desc->busdev[sizeof(desc->busdev) - 1] = '\0';
> > >   	ret = nfp_acquire_process_lock(desc);
> > >   	if (ret)
> > As with previous patch, a better fix is to use strlcpy. This would apply to
> > just about all uses of strncpy in the code.
> 
> OK.
> 
> But the strncpy() was already there, it's not introduced by the patch.
> 
> I agree just doing it in one hit with strlcpy() is nicer.
> 
> -Andy
> 
Thanks for the fixes!