From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hunt Subject: [PATCH] test: fix incorrect cast in pipeline unit test Date: Thu, 10 May 2018 08:38:15 +0100 Message-ID: <20180510073815.76926-1-david.hunt@intel.com> Cc: cristian.dumitrescu@intel.com, David Hunt To: dev@dpdk.org Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id BE8181BB18 for ; Thu, 10 May 2018 16:39:12 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" New warning with gcc 8.1: The table_action_stub_miss() function was incorrectly declared as returning a typedef of rte_pipeline_table_action_handler_miss, instead of what it should have been, an int. Changed this to declare the function as returning an int, and now when the action_handler_miss is set to table_action_stub_miss (cast as rte_pipeline_table_action_handler_miss), gcc 8.1 no longer complains about the cast. Fixes: 5205954791cb ("app/test: packet framework unit tests") Signed-off-by: David Hunt --- test/test/test_table_pipeline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test/test_table_pipeline.c b/test/test/test_table_pipeline.c index 055a1a4e7..5ec4c5244 100644 --- a/test/test/test_table_pipeline.c +++ b/test/test/test_table_pipeline.c @@ -69,7 +69,7 @@ rte_pipeline_table_action_handler_hit table_action_stub_hit(struct rte_pipeline *p, struct rte_mbuf **pkts, uint64_t pkts_mask, struct rte_pipeline_table_entry **entry, void *arg); -rte_pipeline_table_action_handler_miss +static int table_action_stub_miss(struct rte_pipeline *p, struct rte_mbuf **pkts, uint64_t pkts_mask, struct rte_pipeline_table_entry **entry, void *arg); @@ -101,7 +101,7 @@ table_action_stub_hit(__attribute__((unused)) struct rte_pipeline *p, return 0; } -rte_pipeline_table_action_handler_miss +static int table_action_stub_miss(struct rte_pipeline *p, __attribute__((unused)) struct rte_mbuf **pkts, uint64_t pkts_mask, -- 2.17.0