From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [dpdk-stable] [PATCH v2] eventdev: make ethernet
 port identifiers 16 bit
Date: Thu, 10 May 2018 20:00:21 +0530
Message-ID: <20180510143020.GA21914@jerin>
References: <1525893452-155596-1-git-send-email-nikhil.rao@intel.com>
 <1525899160-169278-1-git-send-email-nikhil.rao@intel.com>
 <20180510043154.GA17339@jerin> <18183719.QCaNLk8Ax1@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Nikhil Rao <nikhil.rao@intel.com>, ferruh.yigit@intel.com,
 lei.a.yao@intel.com, dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0086.outbound.protection.outlook.com [104.47.32.86])
 by dpdk.org (Postfix) with ESMTP id F26E81BB5D
 for <dev@dpdk.org>; Thu, 10 May 2018 16:30:41 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <18183719.QCaNLk8Ax1@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Thu, 10 May 2018 15:48:54 +0200
> From: Thomas Monjalon <thomas@monjalon.net>
> To: Nikhil Rao <nikhil.rao@intel.com>
> Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>, ferruh.yigit@intel.com,
>  lei.a.yao@intel.com, dev@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH v2] eventdev: make ethernet port
>  identifiers 16 bit
> 
> 10/05/2018 06:31, Jerin Jacob:
> > > Date: Thu, 10 May 2018 02:22:40 +0530
> > > From: Nikhil Rao <nikhil.rao@intel.com>
> > > 
> > > Ethernet port ID data size has been extended to 16 bits size 17.11
> > > Update the Rx event adapter interface and implementation accordingly.
> > > 
> > > Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation")
> > > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> > > Cc: stable@dpdk.org
> > 
> > Since it is an ABI change, please bump the library version.
> > eth_rx_adapter still under experimental tag, IMO, no deprecation notice is
> > required.
> 
> The ABI changes must be described in the release notes too.
> 
> There is no deprecation notice for this ABI change.
> According the the policy, you must send a notice in 18.05,
> and do the change in 18.08.

Even for the APIs with experimental tag? If so, I don't see any
difference between experimental vs non experimental API? 

> 
> This commit will be dropped when pulling the eventdev tree, sorry.
> 
> 
>